Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample App Initial Commit #364

Open
wants to merge 7 commits into
base: integration
Choose a base branch
from

Conversation

v-raghulraja
Copy link

@v-raghulraja v-raghulraja commented Aug 22, 2024

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Checklist

  • The code change is covered by unit tests. I have added tests that prove my fix is effective or that my feature works
  • I have performed end-to-end test locally.
  • New and existing unit tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I used clear names for everything
  • I have performed a self-review of my own code

@v-raghulraja v-raghulraja requested a review from a team as a code owner August 22, 2024 07:10
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
Microsoft.PowerApps.TestEngine 0% 0% 1173
Microsoft.PowerApps.TestEngine.Tests 0% 0% 652
testengine.user.browser 58% 50% 15
Microsoft.PowerApps.TestEngine 1% 0% 1173
Microsoft.PowerApps.TestEngine.Tests 0% 1% 652
testengine.user.environment 95% 91% 31
Microsoft.PowerApps.TestEngine 0% 0% 1173
testengine.auth.localcertificate 100% 100% 7
Microsoft.PowerApps.TestEngine 0% 0% 1173
testengine.module.mda 94% 100% 34
Microsoft.PowerApps.TestEngine 1% 0% 1173
Microsoft.PowerApps.TestEngine.Tests 0% 1% 652
testengine.user.environment 95% 91% 31
Microsoft.PowerApps.TestEngine 1% 0% 1173
Microsoft.PowerApps.TestEngine.Tests 0% 1% 652
testengine.auth.localcertificate 0% 0% 7
testengine.user.certificate 77% 67% 59
Microsoft.PowerApps.TestEngine 0% 0% 1173
Microsoft.PowerApps.TestEngine.Tests 0% 0% 652
testengine.user.browser 58% 50% 15
Microsoft.PowerApps.TestEngine 89% 86% 1177
Microsoft.PowerApps.TestEngine 4% 3% 1173
testengine.provider.mda 53% 60% 115
Microsoft.PowerApps.TestEngine 5% 3% 1173
Microsoft.PowerApps.TestEngine.Tests 1% 2% 652
testengine.provider.canvas 81% 87% 93
Microsoft.PowerApps.TestEngine 1% 0% 1173
testengine.module.pause 100% 100% 6
Microsoft.PowerApps.TestEngine 0% 0% 1173
testengine.auth.certificatestore 100% 100% 11
Microsoft.PowerApps.TestEngine 0% 0% 1173
testengine.auth.certificatestore 100% 100% 11
Microsoft.PowerApps.TestEngine 0% 0% 1173
testengine.auth.localcertificate 100% 100% 7
Microsoft.PowerApps.TestEngine 89% 86% 1177
Microsoft.PowerApps.TestEngine 1% 0% 1173
testengine.module.pause 100% 100% 6
Microsoft.PowerApps.TestEngine 1% 0% 1173
Microsoft.PowerApps.TestEngine.Tests 0% 1% 652
testengine.auth.localcertificate 0% 0% 7
testengine.user.certificate 77% 67% 59
Microsoft.PowerApps.TestEngine 0% 0% 1173
testengine.module.mda 94% 100% 34
Microsoft.PowerApps.TestEngine 5% 3% 1173
Microsoft.PowerApps.TestEngine.Tests 1% 2% 652
testengine.provider.canvas 81% 87% 93
Summary 11% (5345 / 76714) 11% (1916 / 19282) 28152

Minimum allowed line rate is 10%

@snamilikonda
Copy link

same here asserts are not for 2 parameters, add equal checks in first parameter itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants