Extend browser user authentication provide to handle Condition Access #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| { | ||
| if (await page.IsVisibleAsync($"[data-test-id=\"{personaEmail}\"]")) | ||
| { | ||
| logger.LogInformation($"Selecting {personaEmail}"); |
Check warning
Code scanning / CodeQL
Exposure of private information Medium test
Minimum allowed line rate is |
snamilikonda
reviewed
Aug 7, 2024
| { | ||
| // Default to msedge browser | ||
| launchOptions.Channel = "msedge"; | ||
| } |
There was a problem hiding this comment.
can we reset the channel to input value from the user if it is specifically requested in the yaml
snamilikonda
reviewed
Aug 7, 2024
| { | ||
| var complete = false; | ||
|
|
||
| var persona = testState.GetTestSuiteDefinition().Persona; |
There was a problem hiding this comment.
null checks for the definition, persona and email
snamilikonda
reviewed
Aug 7, 2024
| } | ||
| } | ||
|
|
||
| if (!complete) |
There was a problem hiding this comment.
would it make sense to add a pause here to wait for user to attempt login
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Provide additional steps in the browser based authentication to handle conditional access using provider.
Checklist