Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding namespace checks and support for Power FX #330 #332

Open
wants to merge 1 commit into
base: integration
Choose a base branch
from

Conversation

Grant-Archibald-MS
Copy link
Contributor

@Grant-Archibald-MS Grant-Archibald-MS commented Jun 6, 2024

Pull Request Template

Description

Adding the ability to require namespaces for Test Engine Power FX functions to prevent clashes root namespace functions provided in the Power FX engine.

Checklist

  • The code change is covered by unit tests. I have added tests that prove my fix is effective or that my feature works
  • I have performed end-to-end test locally.
  • New and existing unit tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I used clear names for everything
  • I have performed a self-review of my own code

@Grant-Archibald-MS Grant-Archibald-MS requested a review from a team as a code owner June 6, 2024 18:11
Copy link

github-actions bot commented Jun 6, 2024

Code Coverage

Package Line Rate Branch Rate Complexity Health
Microsoft.PowerApps.TestEngine 0% 0% 1210
Microsoft.PowerApps.TestEngine.Tests 0% 0% 646
testengine.user.browser 58% 50% 15
Microsoft.PowerApps.TestEngine 90% 86% 1214
Microsoft.PowerApps.TestEngine 0% 0% 1210
Microsoft.PowerApps.TestEngine.Tests 0% 0% 646
testengine.user.browser 58% 50% 15
Microsoft.PowerApps.TestEngine 5% 3% 1210
Microsoft.PowerApps.TestEngine.Tests 1% 2% 646
testengine.provider.canvas 81% 87% 93
Microsoft.PowerApps.TestEngine 90% 86% 1214
Microsoft.PowerApps.TestEngine 1% 0% 1210
Microsoft.PowerApps.TestEngine.Tests 0% 1% 646
testengine.user.environment 95% 91% 31
Microsoft.PowerApps.TestEngine 1% 0% 1210
testengine.module.pause 100% 100% 6
Microsoft.PowerApps.TestEngine 5% 3% 1210
Microsoft.PowerApps.TestEngine.Tests 1% 2% 646
testengine.provider.canvas 81% 87% 93
Microsoft.PowerApps.TestEngine 1% 0% 1210
testengine.module.pause 100% 100% 6
Microsoft.PowerApps.TestEngine 1% 0% 1210
Microsoft.PowerApps.TestEngine.Tests 0% 1% 646
testengine.user.environment 95% 91% 31
Summary 20% (4786 / 48984) 19% (1766 / 11132) 16274

Minimum allowed line rate is 15%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant