Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request unifies the Remove functions between PFx and PA.
AI-generated description below:
This pull request introduces several changes to support new Remove/RemoveAll mutation function behaviors, adds a new enum type for remove flags, and updates localization and feature configuration. The most significant changes are grouped below.
Mutation Function Enhancements:
RemoveFunctionwith new implementations:RemoveImplandRemoveAllImpl, which both use a shared async core logic inMutationUtils.RemoveCoreto handle record removal, including support for the "All" flag. (RemoveImpl,RemoveAllImpl,MutationUtils.cs) [1] [2] [3]MutationUtils.cs)Enum and Symbol Table Updates:
RemoveFlagsEnum, with values "First" and "All", and registers it in the enum store and language constants for use in mutation functions. (BuiltInEnums.cs,EnumStoreBuilder.cs,LanguageConstants.cs) [1] [2] [3] [4]EnumStoreBuilderis initialized before adding functions that require enums, preventing possible null reference issues. (SymbolTable.cs)Feature Flags and Configuration:
IsRemoveAllDelegationEnabled, to control RemoveAll delegation behavior, and ensures it is included in feature copying and default feature sets. (Features.cs) [1] [2] [3]Localization and Error Handling:
Strings.cs) [1] [2] [3]RemoveAsyncby omitting unnecessary error messages when a record is not found. (CollectionTableValue.cs)Miscellaneous:
using System.Collections.Generic;directive fromIExternalDocumentProperties.csfor cleanup.