Engine configuration for UDT supported data types #2969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Public API changes: |
1 similar comment
Contributor
|
Public API changes: |
Contributor
|
✅ No public API change. |
2 similar comments
Contributor
|
✅ No public API change. |
Contributor
|
✅ No public API change. |
…er-fx into gregli/udt-decimal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, UDFs and UDTs have a restricted type list in UserDefinitions.cs that is not customizable per host. It includes Decimal which makes sense for Canvas but doesn't work for C# hosts. We need to generalize this.
This PR uses the Engine.PrimitiveTypes list, to be set by a host that cares about UDFs, UDTs, or JSON serialization. It is null by default, and if a host doesn't use these features, it doesn't matter. RecalcEngine will provide PrimitiveTypes that the interpreter can support, so any hosts using it, which is most hosts, don't need to make a change.