Skip to content

Do not incldue the connector response in the message #2956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Robulane wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Do not incldue the connector response in the message #2956

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2beda88
Do not incldue the connector response in the message
Robulane Aug 27, 2025
998f3f2
use warning instead of error
Robulane Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/Microsoft.PowerFx.Connectors/ConnectorFunction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -845,7 +845,7 @@ private async Task<FormulaValue> PostProcessResultAsync(FormulaValue result, Bas

if (result is ErrorValue ev && (er = ev.Errors.FirstOrDefault(e => e.Kind == ErrorKind.Network)) != null)
{
runtimeContext.ExecutionLogger?.LogError($"{this.LogFunction(nameof(PostProcessResultAsync))}, ErrorValue is returned with {er.Message}");
runtimeContext.ExecutionLogger?.LogWarning($"{this.LogFunction(nameof(PostProcessResultAsync))}, ErrorValue is returned with {er.Message}");
result = FormulaValue.NewError(new ExpressionError() { Kind = er.Kind, Severity = er.Severity, Message = $"{DPath.Root.Append(new DName(Namespace)).ToDottedSyntax()}.{Name} failed: {er.Message}" }, ev.Type);
}

Expand Down
4 changes: 2 additions & 2 deletions src/libraries/Microsoft.PowerFx.Connectors/Execution/HttpFunctionInvoker.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,15 +440,15 @@ public async Task<FormulaValue> DecodeResponseAsync(HttpResponseMessage response

if (throwOnError)
{
throw new HttpRequestException($"Http Status Error {statusCode}{reasonPhrase}: {text}");
throw new HttpRequestException($"Http Status Error {statusCode}{reasonPhrase}");
}

return FormulaValue.NewError(
new ExpressionError()
{
Kind = ErrorKind.Network,
Severity = ErrorSeverity.Critical,
Message = $"The server returned an HTTP error with code {statusCode}{reasonPhrase}. Response: {text}"
Message = $"The server returned an HTTP error with code {statusCode}{reasonPhrase}."
},
_function.ReturnType);
}
Expand Down