Skip to content

Conversation

@LucGenetier
Copy link
Contributor

No description provided.

@LucGenetier LucGenetier requested a review from a team as a code owner December 18, 2024 13:26
@LucGenetier LucGenetier linked an issue Dec 18, 2024 that may be closed by this pull request
@LucGenetier
Copy link
Contributor Author

✅ No public API change.

@MikeStall
Copy link
Contributor

MikeStall commented Dec 18, 2024

    protected internal static async Task<T> GetObject<T>(HttpClient httpClient, string message, string uri, string content, CancellationToken cancellationToken, ConnectorLogger logger = null, [CallerMemberName] string callingMethod = "")

can we remove (coming from httpClient now).
Ditto for cases below.


Refers to: src/libraries/Microsoft.PowerFx.Connectors/Tabular/Services/CdpServiceBase.cs:21 in 7a35813. [](commit_id = 7a35813, deletion_comment = False)

@LucGenetier
Copy link
Contributor Author

    protected internal static async Task<T> GetObject<T>(HttpClient httpClient, string message, string uri, string content, CancellationToken cancellationToken, ConnectorLogger logger = null, [CallerMemberName] string callingMethod = "")

This method is used in CdpDataSource to convert Http responses to POCOs
I don't understand why we'd remove it


In reply to: 2551745584


Refers to: src/libraries/Microsoft.PowerFx.Connectors/Tabular/Services/CdpServiceBase.cs:21 in 7a35813. [](commit_id = 7a35813, deletion_comment = False)

@LucGenetier
Copy link
Contributor Author

✅ No public API change.

@LucGenetier
Copy link
Contributor Author

✅ No public API change.

@MikeStall
Copy link
Contributor

My concern about current PR is that it duplicates the code. I'm we can solve this in a way that avoids duplicating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Connectors shouldn't need both HttpClient and uriPrefix

3 participants