Skip to content

Fix stale Pylance resolution in cached builds #8588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StellaHuang95 merged 3 commits into from
Jul 23, 2026
+13 −8
Merged

Fix stale Pylance resolution in cached builds #8588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e3c263
Fix stale Pylance resolution in cached builds
StellaHuang95 Jul 23, 2026
4194531
Use Node 24 to restore Pylance
StellaHuang95 Jul 23, 2026
0b0b54b
Remove obsolete npm always-auth setting
StellaHuang95 Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,4 @@
# registry=https://pkgs.dev.azure.com/devdiv/_packaging/Pylance/npm/registry/
registry=https://pkgs.dev.azure.com/azure-public/vside/_packaging/msft_consumption/npm/registry/

always-auth=true
package-lock=false
4 changes: 2 additions & 2 deletions Build/PreBuild.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,8 @@ try {
"Pylance version = $pylanceVersion"
"Pylance release type = $pylanceReleaseType"

# Get all the versions in the feed in descending order
$versions = npm view @pylance/pylance versions --json | ConvertFrom-Json
# CI prefers cached data for installs, but "latest" must refresh registry metadata.
$versions = npm view @pylance/pylance versions --json --prefer-offline=false --prefer-online=true | ConvertFrom-Json
[array]::Reverse($versions)

# Find the highest version with an appropriate patch number.
Expand Down
16 changes: 11 additions & 5 deletions Build/templates/restore_packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@ parameters:

steps:

# Pylance releases require Node.js 24 or newer.
- task: NodeTool@0
displayName: 'Use Node.js 24'
inputs:
versionSpec: '24.x'

# Point NuGet HTTP cache to a pipeline-controlled location so we can cache it between runs.
# packages.config restores don't use the global-packages folder, but they do use the HTTP cache
# to avoid re-downloading packages from the feed.
Expand Down Expand Up @@ -78,27 +84,27 @@ steps:
- task: Cache@2
displayName: 'Cache node_modules'
inputs:
key: 'node_modules | "$(Agent.OS)" | package.json | ${{ parameters.pylanceVersion }} | ${{ parameters.pylanceReleaseType }}'
key: 'node_modules | "$(Agent.OS)" | "${{ parameters.pylanceVersion }}" | "${{ parameters.pylanceReleaseType }}" | package.json'
restoreKeys: |
node_modules | "$(Agent.OS)" | package.json
node_modules | "$(Agent.OS)" | "${{ parameters.pylanceVersion }}" | "${{ parameters.pylanceReleaseType }}"
node_modules | "$(Agent.OS)"
path: '$(Build.SourcesDirectory)\\node_modules'

# Cache npm downloads to speed up Pylance install (PreBuild.ps1 runs `npm install`)
- task: Cache@2
displayName: 'Cache npm'
inputs:
key: 'npm | "$(Agent.OS)" | package.json | ${{ parameters.pylanceVersion }} | ${{ parameters.pylanceReleaseType }}'
key: 'npm | "$(Agent.OS)" | "${{ parameters.pylanceVersion }}" | "${{ parameters.pylanceReleaseType }}" | package.json'
restoreKeys: |
npm | "$(Agent.OS)" | package.json
npm | "$(Agent.OS)" | "${{ parameters.pylanceVersion }}" | "${{ parameters.pylanceReleaseType }}"
npm | "$(Agent.OS)"
path: '$(Pipeline.Workspace)\\npm-cache'

# Cache PyPI wheel downloads used by install_pypi_package.py (debugpy/etwtrace)
- task: Cache@2
displayName: 'Cache PyPI wheels'
inputs:
key: 'pypi-wheels | "$(Agent.OS)" | ${{ parameters.debugpyVersion }}'
key: 'pypi-wheels | "$(Agent.OS)" | "${{ parameters.debugpyVersion }}"'
restoreKeys: |
pypi-wheels | "$(Agent.OS)"
path: '$(Pipeline.Workspace)\\pypi-wheel-cache'
Expand Down