Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made bounds control more overridable #11819

Closed
wants to merge 1 commit into from
Closed

Made bounds control more overridable #11819

wants to merge 1 commit into from

Conversation

HossamBasion
Copy link

Overview

Made four functions in BoundControl.cs public virtual instead of private and internal

@@ -530,7 +530,7 @@ private void Awake()
}
}

private void Update()
public virtual void Update()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest to make these protected virtual so we aren't allowing outside classes to call them manually

@keveleigh
Copy link
Contributor

@HossamBasion it looks like this PR is targeting MRTK3, so it should probably go into the new repo at https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity

@HossamBasion HossamBasion closed this by deleting the head repository Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants