[MRKT3] Making custom reticles a bit easier in MRTK3. #11758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r in MRTK. The custom reticle is now attached to the base recticle's root transform, removing the need for the custom reticle to position itself. Also, reverting changes made to `RecticleMagnetism`, this now is using an interface again for setting progress, instead of requiring a RingReticle component. Instead of using the old `IVariableReticle` its not `IVariableProgressReticle` to better indicate the propose of the interface. I also rename the newer `IVariableReticle` to `RecticleVisual` to better indicate its purpose.
shaynie
requested changes
Aug 4, 2023
com.microsoft.mrtk.input/Interactors/InteractorVisuals/BaseReticleVisual.cs
Show resolved
Hide resolved
com.microsoft.mrtk.input/Interactors/InteractorVisuals/BaseReticleVisual.cs
Show resolved
Hide resolved
shaynie
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The intent of this change is to make attaching a custom reticle easier in MRTK3. The custom reticle is now attached to the base reticle's root transform, removing the need for the custom reticle to position itself.
Also, reverting changes made to
RecticleMagnetism. With this change,RecticleMagnetismsonce again uses an interface for setting progress, instead of requiring aRingReticlecomponent. Also, instead of using the oldIVariableReticle,RecticleMagnetismsis now usingIVariableProgressReticleto better indicate the propose of the interface.I also rename the newer
IVariableReticletoIRecticleVisualto better indicate its purpose.This change is in response to #11751
Changes