Consolidate LocateTargetHitPoint methods #11699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMollis
requested changes
Jul 12, 2023
com.microsoft.mrtk.input/Interactors/InteractorVisuals/Lines/LineUtility.cs
Outdated
Show resolved
Hide resolved
com.microsoft.mrtk.input/Interactors/InteractorVisuals/Lines/LineUtility.cs
Outdated
Show resolved
Hide resolved
AMollis
requested changes
Jul 12, 2023
com.microsoft.mrtk.input/Interactors/XRRayInteractorExtensions.cs
Outdated
Show resolved
Hide resolved
com.microsoft.mrtk.input/Interactors/XRRayInteractorExtensions.cs
Outdated
Show resolved
Hide resolved
AMollis
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Consolidating the three LocateTargetHitPoint methods into one, a static helper which lives in the LineUtility class. This will take an XRRayInteractor and an IXRSelectInteractable, and will return the target local hit point, target local hit normal, target transform, and a reference point for calculating hit distance.
Changes
MRTKRayReticleVisual::LocateTargetHitPointto common location so it can be shared #11649.