-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Spatial Mouse to MRTK3 #11643
Merged
marlenaklein-msft
merged 22 commits into
microsoft:mrtk3
from
marlenaklein-msft:SpatialMouseAdded
Jun 26, 2023
Merged
Adding Spatial Mouse to MRTK3 #11643
marlenaklein-msft
merged 22 commits into
microsoft:mrtk3
from
marlenaklein-msft:SpatialMouseAdded
Jun 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validate spatial mouse PR
AMollis
requested changes
Jun 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still reviewing...but here's some comments
com.microsoft.mrtk.input/Experimental/SpatialMouse/Interactor/SpatialMouseInteractor.cs
Show resolved
Hide resolved
com.microsoft.mrtk.input/Experimental/SpatialMouse/Interactor/SpatialMouseInteractor.cs
Outdated
Show resolved
Hide resolved
com.microsoft.mrtk.input/Experimental/SpatialMouse/Interactor/SpatialMouseInteractor.cs
Outdated
Show resolved
Hide resolved
com.microsoft.mrtk.input/Experimental/SpatialMouse/Interactor/SpatialMouseInteractor.cs
Outdated
Show resolved
Hide resolved
AMollis
requested changes
Jun 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more changes requeseted
com.microsoft.mrtk.input/Experimental/SpatialMouse/Interactor/SpatialMouseInteractor.cs
Outdated
Show resolved
Hide resolved
com.microsoft.mrtk.input/Experimental/SpatialMouse/Interactor/SpatialMouseInteractor.cs
Show resolved
Hide resolved
com.microsoft.mrtk.input/Experimental/SpatialMouse/Interactor/SpatialMouseInteractor.cs
Show resolved
Hide resolved
...rosoft.mrtk.input/Experimental/SpatialMouse/Interactor/SpatialMouseInteractorCursorVisual.cs
Outdated
Show resolved
Hide resolved
...rosoft.mrtk.input/Experimental/SpatialMouse/Interactor/SpatialMouseInteractorCursorVisual.cs
Outdated
Show resolved
Hide resolved
...rosoft.mrtk.input/Experimental/SpatialMouse/Interactor/SpatialMouseInteractorCursorVisual.cs
Outdated
Show resolved
Hide resolved
AMollis
approved these changes
Jun 26, 2023
This was referenced Jun 27, 2023
Closed
keveleigh
reviewed
Jul 14, 2023
com.microsoft.mrtk.input/Experimental/SpatialMouse/MRTK Gaze Controller.prefab
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds a new controller that can be added to the MRTK XR Rig to enable a spatial mouse. This is an experimental feature.
Updates #10690. Main changes: fix Z-scroll bug, fix last known depth bug, modify interactor to work with custom cursors, and move the spatial mouse input action map bindings into the default MRTK input action map,
Changes