Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Spatial Mouse to MRTK3 #11643

Merged
merged 22 commits into from
Jun 26, 2023

Conversation

marlenaklein-msft
Copy link
Contributor

@marlenaklein-msft marlenaklein-msft commented Jun 22, 2023

Overview

Adds a new controller that can be added to the MRTK XR Rig to enable a spatial mouse. This is an experimental feature.

Updates #10690. Main changes: fix Z-scroll bug, fix last known depth bug, modify interactor to work with custom cursors, and move the spatial mouse input action map bindings into the default MRTK input action map,

Changes

@github-actions github-actions bot added the MRTK3 label Jun 22, 2023
Copy link
Member

@AMollis AMollis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still reviewing...but here's some comments

@AMollis AMollis changed the title Adding Spatial Mouse Adding Spatial Mouse to MRTK3 Jun 22, 2023
Copy link
Member

@AMollis AMollis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more changes requeseted

@marlenaklein-msft marlenaklein-msft marked this pull request as ready for review June 23, 2023 21:56
@marlenaklein-msft marlenaklein-msft merged commit 64922a3 into microsoft:mrtk3 Jun 26, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants