Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update packaging scripts to modify the package dependencies with the new versions #11623

Merged
merged 9 commits into from
Jun 19, 2023
Merged

Update packaging scripts to modify the package dependencies with the new versions #11623

merged 9 commits into from
Jun 19, 2023

Conversation

shaynie
Copy link
Collaborator

@shaynie shaynie commented Jun 13, 2023

Overview

Update packaging scripts to modify the package dependencies with the new versions

Sample output:
Package:
Patching dependency com.microsoft.mrtk.uxcore from 3.0.0-prerelease.pre.17.230613.0 to 3.0.0-pre.17
Patching dependency com.microsoft.mrtk.core from 3.0.0-prerelease.pre.17.230613.0 to 3.0.0-pre.17
Patching dependency com.microsoft.mrtk.input from 3.0.0-prerelease.pre.17.230613.0 to 3.0.0-pre.17
Patching dependency com.microsoft.mrtk.spatialmanipulation from 3.0.0-pre.17 to 3.0.0-pre.17

Changes

Verification

This optional section is a place where you can detail the specific type of verification
you want from reviewers. For example, if you want reviewers to checkout the PR locally
and validate the functionality of specific scenarios, provide instructions
on the specific scenarios and what you want verified.

If there are specific areas of concern or question feel free to highlight them here so
that reviewers can watch out for those issues.

As a reviewer, it is possible to check out this change locally by using the following
commands (substituting {PR_ID} with the ID of this pull request):

git fetch origin pull/{PR_ID}/head:name_of_local_branch

git checkout name_of_local_branch

@github-actions github-actions bot added the MRTK3 label Jun 13, 2023
AMollis
AMollis approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@AMollis AMollis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine.

Please make sure to run the prerelease pipeline, run the repackage-for-release against the results, and manually verify the package.json files :)

@shaynie shaynie enabled auto-merge (squash) June 19, 2023 16:10
@shaynie shaynie merged commit 177e8ac into microsoft:mrtk3 Jun 19, 2023
7 checks passed
@shaynie shaynie deleted the user/shaynie/fixDependenciesInPackaging branch June 20, 2023 16:16
drusk-unity pushed a commit to drusk-unity/MixedRealityToolkit-Unity that referenced this pull request Jun 26, 2023
@shaynie
Update packaging scripts to modify the package dependencies with the …
018896b 
…new versions (microsoft#11623)

* Keep test output modifying to catch all dependencies

* Update packaging script to handle dependency versions

* Fix ouput logging and clean up

* Update the repackage-for-release script to support dependency versions

* Small fix

* Enable cleanup of the repackTempDirectory again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AMollis AMollis AMollis approved these changes

@marlenaklein-msft marlenaklein-msft Awaiting requested review from marlenaklein-msft marlenaklein-msft is a code owner

Assignees
No one assigned
Labels
MRTK3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shaynie @AMollis