Fixes MRTK3's Tap to Place
solver to work with any hand and interactor
#11545
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes MRTK3's
Tap to Place
solver to work with any hand and any interactor (even speech). This change, onStartPlacement
, queries theXRInteractionManager
for all registered interactors, and then registers for the interactors' select events. This is an alternative to requiring the developer to specify particular actions.Note, this change also removes the
StatefulInteractable
requirement. The consumer ofTapToPlace
is now required to determine whenStartPlacement
is invoked. This change is meant to provide extensibility for future scenarios which may not require or useStatefulInteractables
.This also adds Unit Tests to validate
TapToPlace
.Changes
Tap to Place
solver only works with the right hand #11527Verification