Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes MRTK3's Tap to Place solver to work with any hand and interactor #11545

Merged

Conversation

AMollis
Copy link
Member

@AMollis AMollis commented May 8, 2023

Overview

Fixes MRTK3's Tap to Place solver to work with any hand and any interactor (even speech). This change, on StartPlacement, queries the XRInteractionManager for all registered interactors, and then registers for the interactors' select events. This is an alternative to requiring the developer to specify particular actions.

Note, this change also removes the StatefulInteractable requirement. The consumer of TapToPlace is now required to determine when StartPlacement is invoked. This change is meant to provide extensibility for future scenarios which may not require or use StatefulInteractables.

This also adds Unit Tests to validate TapToPlace.

Changes

Verification

This optional section is a place where you can detail the specific type of verification
you want from reviewers. For example, if you want reviewers to checkout the PR locally
and validate the functionality of specific scenarios, provide instructions
on the specific scenarios and what you want verified.

If there are specific areas of concern or question feel free to highlight them here so
that reviewers can watch out for those issues.

As a reviewer, it is possible to check out this change locally by using the following
commands (substituting {PR_ID} with the ID of this pull request):

git fetch origin pull/{PR_ID}/head:name_of_local_branch

git checkout name_of_local_branch

@AMollis AMollis merged commit 77c9125 into microsoft:mrtk3 May 8, 2023
@AMollis AMollis deleted the user/amollis/mrtk3/tap-to-place-changes branch May 8, 2023 22:01
drusk-unity pushed a commit to drusk-unity/MixedRealityToolkit-Unity that referenced this pull request Jun 26, 2023
…tor (microsoft#11545)

## Overview
Fixes MRTK3's `Tap to Place` solver to work with any hand and any interactor (even speech). This change, on `StartPlacement`, queries the `XRInteractionManager` for all registered interactors, and then registers for the interactors' select events.  This is an alternative to requiring the developer to specify particular actions. 

Note, this change also removes the `StatefulInteractable` requirement.  The consumer of `TapToPlace` is now required to determine when `StartPlacement` is invoked. This change is meant to provide extensibility for future scenarios which may not require or use `StatefulInteractables`.

This also adds Unit Tests to validate `TapToPlace`.

## Changes
- Fixes: microsoft#11527
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants