Porting remaining MRTK2 constraints for completeness #11085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RogPodge
requested review from
Zee2,
david-c-kline and
keveleigh
as code owners
keveleigh
reviewed
Oct 6, 2022
com.microsoft.mrtk.spatialmanipulation/Constraints/ConstraintManager.cs
Outdated
Show resolved
Hide resolved
com.microsoft.mrtk.spatialmanipulation/Constraints/RotationAxisConstraint.cs.meta
Show resolved
Hide resolved
…anager.cs Co-authored-by: Kurtis <[email protected]>
keveleigh
approved these changes
Oct 11, 2022
This was referenced Oct 11, 2022
This was referenced Oct 12, 2022
drusk-unity
pushed a commit
to drusk-unity/MixedRealityToolkit-Unity
that referenced
this pull request
Jun 26, 2023
* Porting remaining MRTK2 constraints for completeness * updated documentation to reflect that the constraints system will change in the near future * Update com.microsoft.mrtk.spatialmanipulation/Constraints/ConstraintManager.cs Co-authored-by: Kurtis <[email protected]> * fixing comment typos Co-authored-by: Kurtis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We've gotten requests to add the missing MRTK2 constraints into the spatial manipulation package.
This PR adds those scripts as is, making some additional changes to some other files to smooth out the transition.
These constraints are not intended to be maintained long term, but are added for now to allow MRTK3 users to use the old MRTK2 constraints while we refactor the existing system.
Changes