Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The MRTK3 Tap to Place solver only works with the right hand #11527

Closed
AMollis opened this issue Apr 28, 2023 · 0 comments
Closed

The MRTK3 Tap to Place solver only works with the right hand #11527

AMollis opened this issue Apr 28, 2023 · 0 comments
Assignees
@AMollis
Labels
Bug IssueMigrated MRTK3
Milestone
MRTK v3.0 GA

Comments

@AMollis
Copy link
Member

AMollis commented Apr 28, 2023 •
edited by IssueSyncBot
Loading

This issue has been migrated a new MRTK repository, and the status of this issue will now be tracked at the following location:

Describe the bug

The Tap to Place solve only works with the right hand

To reproduce

Steps to reproduce the behavior:

  1. Open TapToPlaceExample scene
  2. Click the "Head" tap-to-place" target
  3. Using left hand, make select gesture to place target
  4. Result -> target is not placed. You need to use your right hand
  5. Click the "Ray Interactor" target
  6. Try to use your left hand to place the target
  7. Result -> System doesn't follow your left hand. You need to use your right hand

Expected behavior

The left hand to work like the right hand

Your setup (please complete the following information)

  • Unity Version: 2021
  • MRTK Version 3.0.0-pre

Target platform (please complete the following information)

  • HoloLens 2
@AMollis AMollis added the Bug label Apr 28, 2023
@AMollis AMollis added this to the MRTK v3.0 GA milestone Apr 28, 2023
@AMollis AMollis added the MRTK3 label Apr 28, 2023
@AMollis AMollis changed the title The Tap to Place solve only works with the right hand The Tap to Place solver only works with the right hand Apr 28, 2023
@AMollis AMollis changed the title The Tap to Place solver only works with the right hand The MRTK3 Tap to Place solver only works with the right hand Apr 28, 2023
@marlenaklein-msft marlenaklein-msft mentioned this issue May 3, 2023
Closed
@AMollis AMollis mentioned this issue May 8, 2023
Merged
@AMollis AMollis assigned AMollis and unassigned marlenaklein-msft May 8, 2023
AMollis added a commit that referenced this issue May 8, 2023
@AMollis
Fixes MRTK3's Tap to Place solver to work with any hand and interac…
77c9125 
…tor (#11545)

## Overview
Fixes MRTK3's `Tap to Place` solver to work with any hand and any interactor (even speech). This change, on `StartPlacement`, queries the `XRInteractionManager` for all registered interactors, and then registers for the interactors' select events.  This is an alternative to requiring the developer to specify particular actions. 

Note, this change also removes the `StatefulInteractable` requirement.  The consumer of `TapToPlace` is now required to determine when `StartPlacement` is invoked. This change is meant to provide extensibility for future scenarios which may not require or use `StatefulInteractables`.

This also adds Unit Tests to validate `TapToPlace`.

## Changes
- Fixes: #11527
@AMollis AMollis closed this as completed May 8, 2023
drusk-unity pushed a commit to drusk-unity/MixedRealityToolkit-Unity that referenced this issue Jun 26, 2023
@AMollis
Fixes MRTK3's Tap to Place solver to work with any hand and interac…
57c4de1 
…tor (microsoft#11545)

## Overview
Fixes MRTK3's `Tap to Place` solver to work with any hand and any interactor (even speech). This change, on `StartPlacement`, queries the `XRInteractionManager` for all registered interactors, and then registers for the interactors' select events.  This is an alternative to requiring the developer to specify particular actions. 

Note, this change also removes the `StatefulInteractable` requirement.  The consumer of `TapToPlace` is now required to determine when `StartPlacement` is invoked. This change is meant to provide extensibility for future scenarios which may not require or use `StatefulInteractables`.

This also adds Unit Tests to validate `TapToPlace`.

## Changes
- Fixes: microsoft#11527
@IssueSyncBot IssueSyncBot mentioned this issue Aug 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AMollis AMollis

Labels
Bug IssueMigrated MRTK3
Projects
None yet
Milestone
MRTK v3.0 GA
Development

No branches or pull requests
3 participants
@AMollis @marlenaklein-msft @IssueSyncBot