[ci]: fix android job #1158
Merged
[ci]: fix android job #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonRadtke
force-pushed
the
fix-android-ci
branch
20 times, most recently
from
1af193a to
478de58
Compare
Job has been failing for months and is preventing other PRs from getting merged. This PR fixes the pipeline - it changed the following: - runs on macos-latest-large (which is a non-arm image) - starts the emulator under java8 (see https://learn.microsoft.com/en-us/java/openjdk/transition-from-java-8-to-java-11) - runs emulator with -no-audio The above were requirements to get the pipeline running. Other changes include the following: - The job will auto-cancel when a newer commit is pushed to the PR. - The 'Wait for emulator ready' step now has a 2 minute timeout. This is necessary because we get no indication on whether or not the command that started the emulator suceeded. I believe there is room for improvement here, but it is outside the scope of the PR.
carsonRadtke
force-pushed
the
fix-android-ci
branch
from
478de58 to
94203d1
Compare
d-winsor
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Job has been failing for months and is preventing other PRs from getting
merged. This PR fixes the pipeline - it changed the following:
https://learn.microsoft.com/en-us/java/openjdk/transition-from-java-8-to-java-11)
The above were requirements to get the pipeline running. Other changes
include the following:
PR.
is necessary because we get no indication on whether or not the
command that started the emulator suceeded. I believe there is room
for improvement here, but it is outside the scope of the PR.