Skip to content

Bound DDS cubemap counts before face-count conversion #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chuck Walbourn (walbourn) merged 2 commits into from
Sep 29, 2026
Merged

Bound DDS cubemap counts before face-count conversion #745

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6af9e1c
Validate DX10 cubemap face-count conversion on 32-bit builds
Sep 24, 2026
481cb6d
Bound DDS cubemap counts before face-count conversion
Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions DirectXTex/DirectXTexDDS.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,12 @@ namespace
case DDS_DIMENSION_TEXTURE2D:
if (d3d10ext->miscFlag & DDS_RESOURCE_MISC_TEXTURECUBE)
{
// DDS_HEADER_DXT10.arraySize is a count of cubemaps; TexMetadata stores their faces.
if (metadata.arraySize > UINT16_MAX)
{
return HRESULT_E_ARITHMETIC_OVERFLOW;
}

metadata.miscFlags |= TEX_MISC_TEXTURECUBE;
metadata.arraySize *= 6;
}
Expand Down
Loading