Added bit bias when storing R8_UNORM to be consistent with other 8bpp - #671
Merged
Merged
Conversation
Collaborator
Author
|
Test updates |
Copilot started reviewing on behalf of
Chuck Walbourn (walbourn)
February 16, 2026 20:56
View session
There was a problem hiding this comment.
Pull request overview
This PR updates StoreScanline’s float-to-8bpp UNORM conversion to apply a consistent rounding bias for single-channel 8-bit formats (DXGI_FORMAT_R8_UNORM and DXGI_FORMAT_A8_UNORM), aligning their behavior with other 8bpp paths that already apply an 8-bit bias.
Changes:
- Refactors the existing 8-bit bias constant into a scalar
constexpr floatplus anXMVECTORF32variant for vectorized paths. - Adds the 8-bit rounding bias when storing scanlines for
DXGI_FORMAT_R8_UNORMandDXGI_FORMAT_A8_UNORM. - Updates existing vectorized 8bpp conversions to use the renamed bias vector constant.
Nada Ouf (nadaOuf)
approved these changes
Feb 17, 2026
Scott Matloff (scm-xbox)
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a bias in StoreScanline when converting the float values to 8bpp channel specifically for
DXGI_FORMAT_R8_UNORMandDXGI_FORMAT_A8_UNORM. This makes it consistent with other 8bpp formats.