Execution Tests: Fix input sets for FP casts to be in range #7820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damyanp
approved these changes
Oct 14, 2025
spall
approved these changes
Oct 20, 2025
Thought about that and I'm not sure there is a good way to assert that. We could, but it just feels like it is adding too much verbosity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the floating point 'POSITIVE' sets to have values to avoid having a value which produces an out-of-range 16-bit int/uint values when testing ftou and ftoi. Specifically, 3424241.0, is UB as it is larger than uint16_t max.