Fix narrow/wide type comparison in loop condition

microsoft · May 1, 2024 · 248c889 · 248c889
1 parent 5861d8c
commit 248c889
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/include/InputLayout.inl b/include/InputLayout.inl
@@ -39,7 +39,7 @@ namespace D3D11On12
         UINT NumParameters = pVS->m_IOSemantics.m_InputSignature.GetParameters(&pParameters);
 
         // Find each input element's semantic by matching registers
-        for (UINT i = 0; i < m_APIElements.size(); ++i)
+        for (size_t i = 0; i < m_APIElements.size(); ++i)
         {
             UINT Register = m_Registers[i];
             auto iter = std::find_if(pParameters, pParameters + NumParameters,

diff --git a/src/device.cpp b/src/device.cpp
@@ -804,12 +804,12 @@ namespace D3D11On12
             GetBatchedContext().RenameAndMapBuffer(m_spInterfaceBuffers[eShaderType].get(), &Data);
 
             UINT* pDataUINTs = reinterpret_cast<UINT*>(Data.pData);
-            for (UINT i = 0; i < m_InterfaceInstances[eShaderType].size(); ++i)
+            for (size_t i = 0; i < m_InterfaceInstances[eShaderType].size(); ++i)
             {
                 *pDataUINTs = m_InterfaceInstances[eShaderType][i];
                 pDataUINTs += 4; // Legacy CB alignment issues
             }
-            for (UINT i = 0; i < m_InterfacePointerData[eShaderType].size(); ++i)
+            for (size_t i = 0; i < m_InterfacePointerData[eShaderType].size(); ++i)
             {
                 pDataUINTs[0] = m_InterfacePointerData[eShaderType][i].uCBID;
                 pDataUINTs[1] = m_InterfacePointerData[eShaderType][i].uCBOffset;

diff --git a/src/shader.cpp b/src/shader.cpp
@@ -209,7 +209,7 @@ namespace D3D11On12
         // API and DDI decls might be different sizes, because the DDI only allows gaps 4 components at a time
         // Walk the DDI decls, and increment the API decl when: 1. We have a non-gap, or
         // 2. When we've consumed all the DDI decls related to an API gap
-        UINT CurrentAPIDecl = 0, CurrentDDIDecl = 0;
+        size_t CurrentAPIDecl = 0, CurrentDDIDecl = 0;
         UINT CurrentGapOffset = 0;
         for (; CurrentAPIDecl < m_APISODecls.size() && CurrentDDIDecl < m_DDISODecls.size(); ++CurrentDDIDecl)
         {