Fix upgrade if porter install has failed and add tests to resource processor

[marrobi]

Fixes #4281, #4291

• Handle upgrade if porter installation not found
• Add tests to runner and command creation (including move files into helpers directory as resources not liked by pytest).
• Ensure airlock tests are discovered.

[github-actions]

Unit Test Results

21 tests   21 ✅  0s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit e686b4b.

♻️ This comment has been updated with latest results.

[Copilot]

Copilot reviewed 9 out of 12 changed files in this pull request and generated 1 comment.

Files not reviewed (3)

• .devcontainer/devcontainer.json: Language not supported
• resource_processor/resources/helpers.py: Evaluated as low risk
• resource_processor/vmss_porter/runner.py: Evaluated as low risk

Comments suppressed due to low confidence (2)

resource_processor/helpers/commands.py:82

• Concatenation of porter_parameters should use += instead of reassignment for better performance and readability.

porter_parameters = f"{porter_parameters} --param {parameter_name}='{parameter_value}'"

resource_processor/helpers/commands.py:98

• Unnecessary f-string in command_line[0] assignment. It should be command_line[0] += '--force-upgrade '.

command_line[0] = command_line[0] + f"{'--force-upgrade '}"

[Copilot]

Copilot reviewed 9 out of 13 changed files in this pull request and generated 1 comment.

Files not reviewed (4)

• .devcontainer/devcontainer.json: Language not supported
• resource_processor/resources/helpers.py: Evaluated as low risk
• resource_processor/helpers/statuses.py: Evaluated as low risk
• resource_processor/_version.py: Evaluated as low risk

Comments suppressed due to low confidence (1)

resource_processor/helpers/commands.py:97

• The --force-upgrade flag should be added to the command correctly. Consider appending it to the command_line list.

if msg_body['action'] == 'upgrade':

[marrobi]

/test-extended

[github-actions]

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/13243663390 (with refid 49cbdde2)

(in response to this comment from @marrobi)

[github-actions]

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/13243663390 (with refid 49cbdde2)

(in response to this comment from @marrobi)

[marrobi]

Failing on airlock with:

authenticationerrordetail:Signature not valid in the specified time frame: Start [Mon, 10 Feb 2025 22:05:08 GMT] - Expiry [Mon, 10 Feb 2025 23:20:08 GMT] - Current [Mon, 10 Feb 2025 23:20:33 GMT]

Seems like compute clock is an hour wrong or something. Will force approve as has deployed the workspaces etc, and watch for this again.

[marrobi]

/test-force-approve

[github-actions]

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit e686b4b)

(in response to this comment from @marrobi)

[marrobi]

/test-destroy-env

[github-actions]

Destroying PR test environment (RG: rg-tre49cbdde2)... (run: https://github.com/microsoft/AzureTRE/actions/runs/13252796384)