Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query to check if Pods have Requests or Limits #86

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Query to check if Pods have Requests or Limits #86

wants to merge 3 commits into from

Conversation

cmendible
Copy link
Member

No description provided.

@cmendible cmendible changed the title Query to check if Pods have Resources or Limits Query to check if Pods have Requests or Limits Nov 1, 2021
noakup
noakup requested changes Dec 5, 2021
View reviewed changes
Copy link
Member

@noakup noakup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The query description is "check if pods have requests or limits" but it only returns entries "where not(CPURequests) or not(CPULimits) or not(MemoryRequests) or not(MemoryLimits)".
If that's the intention - the description should explain it. Otherwise, the filtering should be removed.

@cmendible
Copy link
Member Author

The query description is "check if pods have requests or limits" but it only returns entries "where not(CPURequests) or not(CPULimits) or not(MemoryRequests) or not(MemoryLimits)". If that's the intention - the description should explain it. Otherwise, the filtering should be removed.

Changed the display name and description in a137ed7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noakup noakup noakup requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmendible @noakup