Skip to content

Nodejs bug template #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Leah (leah-restad) merged 3 commits into from
May 2, 2026
Merged

Nodejs bug template #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4cadb1b
first bug attempt
Apr 29, 2026
074d4e8
license
Apr 29, 2026
2421b20
rename
May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 59 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report_nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
# Copyright (c) Microsoft Corporation.
# Licensed under the MIT License.

name: Bug - Node.js
description: File a bug report for the NodeJS version of the AntiSSRF library.
title: "[Bug][Nodejs]: <title>"
labels: ["bug", "nodejs"]
assignees:
- leah-restad
type: bug
body:
- type: textarea
attributes:
label: Bug Behavior
description: A concise description of what you're experiencing.
validations:
required: false
- type: textarea
attributes:
label: Expected Behavior
description: A concise description of what you expected to happen.
validations:
required: false
- type: textarea
attributes:
label: Steps To Reproduce
description: Steps to reproduce the behavior.
placeholder: |
1. In this environment...
1. With this config...
1. Run '...'
1. See error...
validations:
required: false
- type: textarea
attributes:
label: Environment
description: |
examples:
- **OS**: Ubuntu 20.04
- **Node**: 13.14.0
- **npm**: 7.6.3
value: |
- OS:
- Node:
- npm:
render: markdown
validations:
required: false
- type: textarea
attributes:
label: Anything else?
description: |
Links? References? Anything that will give us more context about the issue you are encountering!

Tip: You can attach images or log files by clicking this area to highlight it and then dragging files in.
validations:
required: false

10 changes: 5 additions & 5 deletions .github/workflows/test-csharp.yml → .github/workflows/test-dotnet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ on:
branches:
- main
paths:
- "csharp/**"
- ".github/workflows/test-csharp.yml"
- "dotnet/**"
- ".github/workflows/test-dotnet.yml"
workflow_dispatch:

jobs:
Expand All @@ -32,10 +32,10 @@ jobs:
dotnet-version: 8.0.x

- name: Restore solution
run: dotnet restore csharp/Microsoft.Security.AntiSSRF.sln
run: dotnet restore dotnet/Microsoft.Security.AntiSSRF.sln

- name: Run UnitTests (${{ matrix.framework }})
run: dotnet test csharp/UnitTests/Microsoft.Security.AntiSSRF.UnitTests.csproj --configuration Release --framework ${{ matrix.framework }} --no-restore
run: dotnet test dotnet/UnitTests/Microsoft.Security.AntiSSRF.UnitTests.csproj --configuration Release --framework ${{ matrix.framework }} --no-restore

- name: Run FunctionalTests (${{ matrix.framework }})
run: dotnet test csharp/FunctionalTests/Microsoft.Security.AntiSSRF.FunctionalTests.csproj --configuration Release --framework ${{ matrix.framework }} --no-restore
run: dotnet test dotnet/FunctionalTests/Microsoft.Security.AntiSSRF.FunctionalTests.csproj --configuration Release --framework ${{ matrix.framework }} --no-restore
12 changes: 6 additions & 6 deletions .github/workflows/update-domains.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@ on:
paths:
- 'config/Domains.json'
- 'nodejs/src/Helpers/Domains.ts'
- 'csharp/src/Helpers/Domains.cs'
- 'dotnet/src/Helpers/Domains.cs'
push:
branches: [main]
paths:
- 'config/Domains.json'
- 'nodejs/src/Helpers/Domains.ts'
- 'csharp/src/Helpers/Domains.cs'
- 'dotnet/src/Helpers/Domains.cs'
workflow_dispatch: # Allow manual triggering

jobs:
Expand All @@ -37,18 +37,18 @@ jobs:
run: ./scripts/build-domains-nodejs.sh

- name: Build C# version
run: ./scripts/build-domains-cs.sh
run: ./scripts/build-domains-dotnet.sh

- name: Verify generated files are up-to-date
run: |
if ! git diff --exit-code nodejs/src/Helpers/Domains.ts csharp/src/Helpers/Domains.cs; then
if ! git diff --exit-code nodejs/src/Helpers/Domains.ts dotnet/src/Helpers/Domains.cs; then
echo "❌ Generated domain files are out of sync!"
echo "The following files need to be regenerated:"
git diff --name-only nodejs/src/Helpers/Domains.ts csharp/src/Helpers/Domains.cs
git diff --name-only nodejs/src/Helpers/Domains.ts dotnet/src/Helpers/Domains.cs
echo ""
echo "Please run the following commands locally and commit the results:"
echo " ./scripts/build-domains-nodejs.sh"
echo " ./scripts/build-domains-cs.sh"
echo " ./scripts/build-domains-dotnet.sh"
exit 1
else
echo "✅ All generated files are up-to-date"
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/update-ip-ranges.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:
paths:
- 'config/IPAddressRanges.json'
- 'nodejs/src/IPAddressRanges.ts'
- 'csharp/src/IPAddressRanges.cs'
- 'dotnet/src/IPAddressRanges.cs'
workflow_dispatch: # Allow manual triggering

jobs:
Expand All @@ -33,18 +33,18 @@ jobs:
run: ./scripts/build-ip-ranges-nodejs.sh

- name: Build C# version
run: ./scripts/build-ip-ranges-cs.sh
run: ./scripts/build-ip-ranges-dotnet.sh

- name: Verify generated files are up-to-date
run: |
if ! git diff --exit-code nodejs/src/IPAddressRanges.ts csharp/src/IPAddressRanges.cs; then
if ! git diff --exit-code nodejs/src/IPAddressRanges.ts dotnet/src/IPAddressRanges.cs; then
echo "❌ Generated IP address range files are out of sync!"
echo "The following files need to be regenerated:"
git diff --name-only nodejs/src/IPAddressRanges.ts csharp/src/IPAddressRanges.cs
git diff --name-only nodejs/src/IPAddressRanges.ts dotnet/src/IPAddressRanges.cs
echo ""
echo "Please run the following commands locally and commit the results:"
echo " ./scripts/build-ip-ranges-nodejs.sh"
echo " ./scripts/build-ip-ranges-cs.sh"
echo " ./scripts/build-ip-ranges-dotnet.sh"
exit 1
else
echo "✅ All generated files are up-to-date"
Expand Down
0 csharp/Directory.Packages.props → dotnet/Directory.Packages.props
View file
Open in desktop
File renamed without changes.
0 ...p/FunctionalTests/AntiSSRFHandlerTests.cs → ...t/FunctionalTests/AntiSSRFHandlerTests.cs
View file
Open in desktop
File renamed without changes.
0 ...Tests/AntiSSRFPolicy.AddXFFHeaderTests.cs → ...Tests/AntiSSRFPolicy.AddXFFHeaderTests.cs
View file
Open in desktop
File renamed without changes.
0 ...ionalTests/AntiSSRFPolicy.AddressTests.cs → ...ionalTests/AntiSSRFPolicy.AddressTests.cs
View file
Open in desktop
File renamed without changes.
0 AntiSSRFPolicy.HeaderTests.cs → ...tionalTests/AntiSSRFPolicy.HeaderTests.cs
100644 → 100755
View file
Open in desktop
File renamed without changes.
0 ...tionalTests/AntiSSRFPolicy.SchemeTests.cs → ...tionalTests/AntiSSRFPolicy.SchemeTests.cs
View file
Open in desktop
File renamed without changes.
0 ...tionalTests/InAzureKeyVaultDomainTests.cs → ...tionalTests/InAzureKeyVaultDomainTests.cs
View file
Open in desktop
File renamed without changes.
0 ...ctionalTests/InAzureStorageDomainTests.cs → ...ctionalTests/InAzureStorageDomainTests.cs
View file
Open in desktop
File renamed without changes.
0 csharp/FunctionalTests/InDomainTests.cs → dotnet/FunctionalTests/InDomainTests.cs
View file
Open in desktop
File renamed without changes.
0 ....Security.AntiSSRF.FunctionalTests.csproj → ....Security.AntiSSRF.FunctionalTests.csproj
View file
Open in desktop
File renamed without changes.
124 changes: 62 additions & 62 deletions csharp/Microsoft.Security.AntiSSRF.sln → dotnet/Microsoft.Security.AntiSSRF.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,62 +1,62 @@

Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio Version 17
VisualStudioVersion = 17.0.31903.59
MinimumVisualStudioVersion = 10.0.40219.1
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Microsoft.Security.AntiSSRF", "src\Microsoft.Security.AntiSSRF.csproj", "{1E54F5AE-BEE8-4E3F-B0D0-ECC5172A911B}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Microsoft.Security.AntiSSRF.UnitTests", "UnitTests\Microsoft.Security.AntiSSRF.UnitTests.csproj", "{0099754E-B40C-4459-860B-B5092231974E}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Microsoft.Security.AntiSSRF.FunctionalTests", "FunctionalTests\Microsoft.Security.AntiSSRF.FunctionalTests.csproj", "{1091AE9C-086A-4CE0-A54D-52A762C8E296}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Any CPU = Debug|Any CPU
Debug|x64 = Debug|x64
Debug|x86 = Debug|x86
Release|Any CPU = Release|Any CPU
Release|x64 = Release|x64
Release|x86 = Release|x86
EndGlobalSection
GlobalSection(ProjectConfigurationPlatforms) = postSolution
{1E54F5AE-BEE8-4E3F-B0D0-ECC5172A911B}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{1E54F5AE-BEE8-4E3F-B0D0-ECC5172A911B}.Debug|Any CPU.Build.0 = Debug|Any CPU
{1E54F5AE-BEE8-4E3F-B0D0-ECC5172A911B}.Debug|x64.ActiveCfg = Debug|Any CPU
{1E54F5AE-BEE8-4E3F-B0D0-ECC5172A911B}.Debug|x64.Build.0 = Debug|Any CPU
{1E54F5AE-BEE8-4E3F-B0D0-ECC5172A911B}.Debug|x86.ActiveCfg = Debug|Any CPU
{1E54F5AE-BEE8-4E3F-B0D0-ECC5172A911B}.Debug|x86.Build.0 = Debug|Any CPU
{1E54F5AE-BEE8-4E3F-B0D0-ECC5172A911B}.Release|Any CPU.ActiveCfg = Release|Any CPU
{1E54F5AE-BEE8-4E3F-B0D0-ECC5172A911B}.Release|Any CPU.Build.0 = Release|Any CPU
{1E54F5AE-BEE8-4E3F-B0D0-ECC5172A911B}.Release|x64.ActiveCfg = Release|Any CPU
{1E54F5AE-BEE8-4E3F-B0D0-ECC5172A911B}.Release|x64.Build.0 = Release|Any CPU
{1E54F5AE-BEE8-4E3F-B0D0-ECC5172A911B}.Release|x86.ActiveCfg = Release|Any CPU
{1E54F5AE-BEE8-4E3F-B0D0-ECC5172A911B}.Release|x86.Build.0 = Release|Any CPU
{0099754E-B40C-4459-860B-B5092231974E}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{0099754E-B40C-4459-860B-B5092231974E}.Debug|Any CPU.Build.0 = Debug|Any CPU
{0099754E-B40C-4459-860B-B5092231974E}.Debug|x64.ActiveCfg = Debug|Any CPU
{0099754E-B40C-4459-860B-B5092231974E}.Debug|x64.Build.0 = Debug|Any CPU
{0099754E-B40C-4459-860B-B5092231974E}.Debug|x86.ActiveCfg = Debug|Any CPU
{0099754E-B40C-4459-860B-B5092231974E}.Debug|x86.Build.0 = Debug|Any CPU
{0099754E-B40C-4459-860B-B5092231974E}.Release|Any CPU.ActiveCfg = Release|Any CPU
{0099754E-B40C-4459-860B-B5092231974E}.Release|Any CPU.Build.0 = Release|Any CPU
{0099754E-B40C-4459-860B-B5092231974E}.Release|x64.ActiveCfg = Release|Any CPU
{0099754E-B40C-4459-860B-B5092231974E}.Release|x64.Build.0 = Release|Any CPU
{0099754E-B40C-4459-860B-B5092231974E}.Release|x86.ActiveCfg = Release|Any CPU
{0099754E-B40C-4459-860B-B5092231974E}.Release|x86.Build.0 = Release|Any CPU
{1091AE9C-086A-4CE0-A54D-52A762C8E296}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{1091AE9C-086A-4CE0-A54D-52A762C8E296}.Debug|Any CPU.Build.0 = Debug|Any CPU
{1091AE9C-086A-4CE0-A54D-52A762C8E296}.Debug|x64.ActiveCfg = Debug|Any CPU
{1091AE9C-086A-4CE0-A54D-52A762C8E296}.Debug|x64.Build.0 = Debug|Any CPU
{1091AE9C-086A-4CE0-A54D-52A762C8E296}.Debug|x86.ActiveCfg = Debug|Any CPU
{1091AE9C-086A-4CE0-A54D-52A762C8E296}.Debug|x86.Build.0 = Debug|Any CPU
{1091AE9C-086A-4CE0-A54D-52A762C8E296}.Release|Any CPU.ActiveCfg = Release|Any CPU
{1091AE9C-086A-4CE0-A54D-52A762C8E296}.Release|Any CPU.Build.0 = Release|Any CPU
{1091AE9C-086A-4CE0-A54D-52A762C8E296}.Release|x64.ActiveCfg = Release|Any CPU
{1091AE9C-086A-4CE0-A54D-52A762C8E296}.Release|x64.Build.0 = Release|Any CPU
{1091AE9C-086A-4CE0-A54D-52A762C8E296}.Release|x86.ActiveCfg = Release|Any CPU
{1091AE9C-086A-4CE0-A54D-52A762C8E296}.Release|x86.Build.0 = Release|Any CPU
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
EndGlobalSection
EndGlobal

Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio Version 17
VisualStudioVersion = 17.0.31903.59
MinimumVisualStudioVersion = 10.0.40219.1
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Microsoft.Security.AntiSSRF", "src\Microsoft.Security.AntiSSRF.csproj", "{1E54F5AE-BEE8-4E3F-B0D0-ECC5172A911B}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Microsoft.Security.AntiSSRF.UnitTests", "UnitTests\Microsoft.Security.AntiSSRF.UnitTests.csproj", "{0099754E-B40C-4459-860B-B5092231974E}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Microsoft.Security.AntiSSRF.FunctionalTests", "FunctionalTests\Microsoft.Security.AntiSSRF.FunctionalTests.csproj", "{1091AE9C-086A-4CE0-A54D-52A762C8E296}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Any CPU = Debug|Any CPU
Debug|x64 = Debug|x64
Debug|x86 = Debug|x86
Release|Any CPU = Release|Any CPU
Release|x64 = Release|x64
Release|x86 = Release|x86
EndGlobalSection
GlobalSection(ProjectConfigurationPlatforms) = postSolution
{1E54F5AE-BEE8-4E3F-B0D0-ECC5172A911B}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{1E54F5AE-BEE8-4E3F-B0D0-ECC5172A911B}.Debug|Any CPU.Build.0 = Debug|Any CPU
{1E54F5AE-BEE8-4E3F-B0D0-ECC5172A911B}.Debug|x64.ActiveCfg = Debug|Any CPU
{1E54F5AE-BEE8-4E3F-B0D0-ECC5172A911B}.Debug|x64.Build.0 = Debug|Any CPU
{1E54F5AE-BEE8-4E3F-B0D0-ECC5172A911B}.Debug|x86.ActiveCfg = Debug|Any CPU
{1E54F5AE-BEE8-4E3F-B0D0-ECC5172A911B}.Debug|x86.Build.0 = Debug|Any CPU
{1E54F5AE-BEE8-4E3F-B0D0-ECC5172A911B}.Release|Any CPU.ActiveCfg = Release|Any CPU
{1E54F5AE-BEE8-4E3F-B0D0-ECC5172A911B}.Release|Any CPU.Build.0 = Release|Any CPU
{1E54F5AE-BEE8-4E3F-B0D0-ECC5172A911B}.Release|x64.ActiveCfg = Release|Any CPU
{1E54F5AE-BEE8-4E3F-B0D0-ECC5172A911B}.Release|x64.Build.0 = Release|Any CPU
{1E54F5AE-BEE8-4E3F-B0D0-ECC5172A911B}.Release|x86.ActiveCfg = Release|Any CPU
{1E54F5AE-BEE8-4E3F-B0D0-ECC5172A911B}.Release|x86.Build.0 = Release|Any CPU
{0099754E-B40C-4459-860B-B5092231974E}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{0099754E-B40C-4459-860B-B5092231974E}.Debug|Any CPU.Build.0 = Debug|Any CPU
{0099754E-B40C-4459-860B-B5092231974E}.Debug|x64.ActiveCfg = Debug|Any CPU
{0099754E-B40C-4459-860B-B5092231974E}.Debug|x64.Build.0 = Debug|Any CPU
{0099754E-B40C-4459-860B-B5092231974E}.Debug|x86.ActiveCfg = Debug|Any CPU
{0099754E-B40C-4459-860B-B5092231974E}.Debug|x86.Build.0 = Debug|Any CPU
{0099754E-B40C-4459-860B-B5092231974E}.Release|Any CPU.ActiveCfg = Release|Any CPU
{0099754E-B40C-4459-860B-B5092231974E}.Release|Any CPU.Build.0 = Release|Any CPU
{0099754E-B40C-4459-860B-B5092231974E}.Release|x64.ActiveCfg = Release|Any CPU
{0099754E-B40C-4459-860B-B5092231974E}.Release|x64.Build.0 = Release|Any CPU
{0099754E-B40C-4459-860B-B5092231974E}.Release|x86.ActiveCfg = Release|Any CPU
{0099754E-B40C-4459-860B-B5092231974E}.Release|x86.Build.0 = Release|Any CPU
{1091AE9C-086A-4CE0-A54D-52A762C8E296}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{1091AE9C-086A-4CE0-A54D-52A762C8E296}.Debug|Any CPU.Build.0 = Debug|Any CPU
{1091AE9C-086A-4CE0-A54D-52A762C8E296}.Debug|x64.ActiveCfg = Debug|Any CPU
{1091AE9C-086A-4CE0-A54D-52A762C8E296}.Debug|x64.Build.0 = Debug|Any CPU
{1091AE9C-086A-4CE0-A54D-52A762C8E296}.Debug|x86.ActiveCfg = Debug|Any CPU
{1091AE9C-086A-4CE0-A54D-52A762C8E296}.Debug|x86.Build.0 = Debug|Any CPU
{1091AE9C-086A-4CE0-A54D-52A762C8E296}.Release|Any CPU.ActiveCfg = Release|Any CPU
{1091AE9C-086A-4CE0-A54D-52A762C8E296}.Release|Any CPU.Build.0 = Release|Any CPU
{1091AE9C-086A-4CE0-A54D-52A762C8E296}.Release|x64.ActiveCfg = Release|Any CPU
{1091AE9C-086A-4CE0-A54D-52A762C8E296}.Release|x64.Build.0 = Release|Any CPU
{1091AE9C-086A-4CE0-A54D-52A762C8E296}.Release|x86.ActiveCfg = Release|Any CPU
{1091AE9C-086A-4CE0-A54D-52A762C8E296}.Release|x86.Build.0 = Release|Any CPU
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
EndGlobalSection
EndGlobal
0 csharp/UnitTests/CIDRBlockTests.cs → dotnet/UnitTests/CIDRBlockTests.cs
View file
Open in desktop
File renamed without changes.
0 ...rosoft.Security.AntiSSRF.UnitTests.csproj → ...rosoft.Security.AntiSSRF.UnitTests.csproj
View file
Open in desktop
File renamed without changes.
0 csharp/src/AntiSSRFException.cs → dotnet/src/AntiSSRFException.cs
View file
Open in desktop
File renamed without changes.
0 csharp/src/AntiSSRFHandler.cs → dotnet/src/AntiSSRFHandler.cs
View file
Open in desktop
File renamed without changes.
0 csharp/src/AntiSSRFPolicy.cs → dotnet/src/AntiSSRFPolicy.cs
View file
Open in desktop
File renamed without changes.
0 csharp/src/Helpers/CIDRBlock.cs → dotnet/src/Helpers/CIDRBlock.cs
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion csharp/src/Helpers/Domains.cs → dotnet/src/Helpers/Domains.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Licensed under the MIT License.

// This file is auto-generated from config/Domains.json
// Do not edit this file directly. Run build-domains-cs.sh to regenerate.
// Do not edit this file directly.

namespace Microsoft.Security.AntiSSRF
{
Expand Down
0 csharp/src/Helpers/InnerHandler.NetCore.cs → dotnet/src/Helpers/InnerHandler.NetCore.cs
View file
Open in desktop
File renamed without changes.
0 ...p/src/Helpers/InnerHandler.NetStandard.cs → ...t/src/Helpers/InnerHandler.NetStandard.cs
View file
Open in desktop
File renamed without changes.
0 csharp/src/Helpers/RedirectHandler.cs → dotnet/src/Helpers/RedirectHandler.cs
View file
Open in desktop
File renamed without changes.
0 csharp/src/IPAddressRanges.cs → dotnet/src/IPAddressRanges.cs
View file
Open in desktop
File renamed without changes.
Loading
Loading