Enforce error handling for promises and improve command execution - #73
Merged
TamasBoncz merged 2 commits intoMay 29, 2026
Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Aymen (aymenfurter)
approved these changes
May 27, 2026
Collaborator
Author
|
@microsoft-github-policy-service agree |
Aymen (aymenfurter)
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request strengthens code quality by tightening linting rules and improves codebase robustness by ensuring that all asynchronous calls are properly handled. The main changes are grouped below:
resolves #21
Linting Rule Updates
@typescript-eslintrules (such asno-floating-promises,no-misused-promises, and others) andimport-x/no-duplicatesfrom "warn" to "error", making violations fail the lint step instead of just warning. This enforces stricter code safety and import hygiene. [1] [2]Asynchronous Call Handling
voidbefore calls tovscode.window.showErrorMessage,vscode.window.showInformationMessage,vscode.commands.executeCommand, and other promise-returning functions to explicitly ignore returned promises, preventing unhandled promise rejections and satisfying stricter linting. [1] [2] [3] [4] [5] [6] [7]Test Import Cleanup
parser-shared.test.tsby combining multiple import statements into a single line for clarity.## DescriptionRelated Issues
Checklist
npm run checkpasses (typecheck + lint + spellcheck + knip + tests)