Skip to content

Add per-sample L4 validation execution - #887

Merged
Brandon Miller (brandom-msft) merged 7 commits into
mainfrom
brandom-msft-p4-0-l4-execution
Aug 6, 2026
Merged

Brandon Miller (brandom-msft) merged 7 commits into
mainfrom
brandom-msft-p4-0-l4-execution

Conversation

@brandom-msft

@brandom-msft Brandon Miller (brandom-msft) commented Aug 6, 2026 •

Copy link
Copy Markdown
Member

Summary

  • add explicit per-sample L4 execution to validate-sample.sh
  • define the opt-in sample.yaml l4.command and required_env contract
  • preserve warm/cold caller-owned SKIP_PROVISION behavior and clean no-declaration success
  • classify L4 solely by normalized exit status (0 pass, 1 fail, 2 error; other nonzero fail)

Validation

  • focused L3/L4 mechanics: 17 passed, 0 failed
  • GitHub-hosted scripts self-test: all jobs passed with real toolchains and Mike Farah yq
  • detector harness: 23 passed, 0 failed
  • Bash syntax and diff checks passed
  • declared warm-project L4 proof passed in GitHub Actions run 31062472629: OIDC login succeeded, the warm endpoint returned pong, and the validator emitted l4_declared=true and verdict=pass

The first hosted proof caught a real yq kind compatibility issue before Azure execution; commit f8156e73 corrected the validator to production yq behavior, and both the full self-test and warm-project proof then passed. The temporary branch-scoped proof workflow was removed from the final diff.

A final rubber-duck pressure test found no merge blockers. Two optional recommendations were adopted as independently revertible commits: exit-code normalization guidance (c143f307) and absent/malformed YAML coverage (c2531338). Buffered L4 output was intentionally retained to honor the accepted capture/preservation requirement.

Tracking

ADO 5480191: https://msdata.visualstudio.com/Vienna/_workitems/edit/5480191

Define the opt-in sample.yaml L4 execution contract, preserve caller-controlled warm and cold provisioning semantics, and cover pass, no-op, failure, and infrastructure classification paths.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: d384d160-f922-4fed-9cd8-c6ffadc653bd
Keep transport-text inference scoped to dedicated dependency installs and require L4 commands to normalize pass, sample failure, and infrastructure error through exit codes 0, 1, and 2.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: d384d160-f922-4fed-9cd8-c6ffadc653bd
Run a branch-scoped declared sample through the L4 validator using the existing warm-project OIDC environment. This workflow will be removed after evidence is captured.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: d384d160-f922-4fed-9cd8-c6ffadc653bd
Match Mike Farah yq kind output for mappings and sequences so declared L4 samples validate with the production parser.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: d384d160-f922-4fed-9cd8-c6ffadc653bd
The declared warm-project validation passed in GitHub Actions run 31062472629, so remove the branch-scoped proof workflow from the review diff.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: d384d160-f922-4fed-9cd8-c6ffadc653bd
Warn sample authors that common tools use exit 2 for sample-side failures and must be wrapped to preserve the L4 infrastructure-error contract.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: d384d160-f922-4fed-9cd8-c6ffadc653bd
Prove that absent sample metadata is a yq-free L4 no-op and malformed YAML remains an infrastructure error.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: d384d160-f922-4fed-9cd8-c6ffadc653bd
@brandom-msft
Brandon Miller (brandom-msft) merged commit 9cbcb52 into main Aug 6, 2026
14 checks passed
@brandom-msft
Brandon Miller (brandom-msft) deleted the brandom-msft-p4-0-l4-execution branch August 6, 2026 21:22

This branch was previously deployed

1 inactive deployment
L4-validation — c2531338 Deployed Aug 6, 2026 by brandom-msft via trusted #46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant