Repository navigation
Preserve ENABLE_WORK_IQ during CI toolbox substitution - #1055
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused implementation matches the stated behavior and includes comprehensive regression coverage.
0 open findings
What changed in this PR
Preserves WorkIQ feature flags when CI substitutes shared toolboxes.
Changes:
- Removes forced
ENABLE_WORK_IQ=trueassignments. - Adds regression coverage for all supported environment shapes.
| File | Description |
|---|---|
prepare-hosted-agent-ci-toolboxes.sh |
Preserves feature flags during toolbox routing substitution. |
test-hosted-agent-ci-toolboxes.sh |
Tests absent, enabled, and disabled WorkIQ settings. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Antriksh Jain (antriksh30)
approved these changes
Oct 9, 2026
Antriksh Jain (antriksh30)
deployed
to
L4-validation
October 9, 2026 05:48 — with 
GitHub Actions
Active
GitHub Actions
Active
Wei Meng (m5i-work)
enabled auto-merge (squash)
October 9, 2026 05:50
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The hosted-agent cloud E2E runner copies sample manifests into a job-local workspace and replaces their declared toolboxes with shared test toolboxes. During that substitution,
prepare-hosted-agent-ci-toolboxes.shalso unconditionally setsENABLE_WORK_IQ=trueacross all supported environment shapes.The Python
agent-framework/responses/07-teams-activitysample explicitly declaresENABLE_WORK_IQ: 'false'. Enabling it implicitly in app-only CI triggers WorkIQ tool discovery without the delegated Microsoft Entra user context those tools require. Both container and code deployment cells failed with that identity error in daily build 239410755.Minimal fix
env,environmentVariables, andconfig.env, and update the actual Python Teams manifest check to expect its existing disabled setting.No sample implementation, pipeline retry, credential, skip-list, or merge-policy changes are included. With WorkIQ disabled, the Python Teams job remains a deployment/chat smoke test; this does not validate Teams/calendar integration or repair GitHub MCP authentication.
Validation
shared preparation must preserve WorkIQ in .env (want=false got=true).test-hosted-agent-ci-toolboxes.sh: passed, including real sample manifests and cleanup mocks.bash -non both changed scripts: passed.git diff --check: passed.No manual live deployments or pipeline reruns were performed. Shared lifecycle-helper changes select the full cloud E2E matrix on this PR, so unrelated known GitHub MCP credential failures may still make that required check fail.