python-ecosys/aiohttp: fix header - case-insensitivity #972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The pipeline is failing for an unrelated reason (version of GHA upload artifact) |
FuNK3Y
force-pushed
the
fix-header-case-sensitivity
branch
3 times, most recently
from
e5fffb6 to
6dddab7
Compare
FuNK3Y
changed the title
|
Thanks for the fix. This is necessary as you point out, to comply with HTTP spec. However I have some suggestions (inline) to optimise it for MicroPython. |
dpgeorge
reviewed
Apr 10, 2025
FuNK3Y
force-pushed
the
fix-header-case-sensitivity
branch
6 times, most recently
from
1610ec7 to
60e6188
Compare
|
@dpgeorge thanks for the proposed changes. I implemented those and tested those successfully. |
According to RFC https://datatracker.ietf.org/doc/html/rfc7230#section-3.2 header names are case-insensitive. This commit makes sure that the module behaves consistently regardless of the casing of "Content-type" and "Content-Length" (other headers are not considered by the module). Without this fix, the client seems to wait for the connection termination (~10 seconds) prior to returning any content if the casing of "Content-Length" is different. Signed-off-by: FuNK3Y <[email protected]>
dpgeorge
force-pushed
the
fix-header-case-sensitivity
branch
from
60e6188 to
86df723
Compare
|
@dpgeorge This should have generated a new version of the module - right? It shows here that the version increased: Here is what I get when I try to install the package: There seems to be nothing above https://micropython.org/pi/v2/package/6/aiohttp/0.0.3.json |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to RFC (https://datatracker.ietf.org/doc/html/rfc7230#section-3.2) header names are case-insensitive.
This PR makes sure that the module behaves consistently regardless of the casing of
Content-typeandContent-Length(other headers are not considered by the module)Without this fix, the client seems to wait for the connection termination (~10 seconds) prior to returning any content if the casing of
Content-Lengthis different.