Skip to content

micropython/umqtt.simple/umqtt: Add support for to umqtt.simple. #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

FallenPhoenix8
Copy link

@FallenPhoenix8 FallenPhoenix8 commented Dec 10, 2024

Summary

  1. Explicit UTF-8 Encoding:
  • Both the topic and msg are now explicitly encoded using UTF-8 (topic.encode('utf-8') and msg.encode('utf-8')).
  1. Accurate Size Calculation:
  • The size of the message (sz) is calculated based on the byte length of the encoded topic and message.

Signed-off-by: FallenPhoenix8 <[email protected]>
@FallenPhoenix8 FallenPhoenix8 changed the title umqtt.simple: Add Unicode support micropython/umqtt.simple/umqtt: Add support for to umqtt.simple. Dec 10, 2024
@dpgeorge
Copy link
Member

Thanks for the contribution, but I'm not sure exactly what this PR is fixing/improving.

The idea with the publish() method is that you should pass in bytes objects for topic and message. This PR will break existing uses of publish() that do pass in bytes (or bytearray) objects.

@FallenPhoenix8
Copy link
Author

Ok, thanks for the information. I'll close the Pull Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants