Skip to content

fix: Allow to remove a ThreadLocalAccessor by Key of Type Object #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 1.1.x
Choose a base branch
from
Open

fix: Allow to remove a ThreadLocalAccessor by Key of Type Object #413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions context-propagation/src/main/java/io/micrometer/context/ContextRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,18 @@ public ContextRegistry registerThreadLocalAccessor(ThreadLocalAccessor<?> access
* Removes a {@link ThreadLocalAccessor}.
* @param key under which the accessor got registered
* @return {@code true} when accessor got successfully removed
* @deprecated use {@link ContextRegistry#removeThreadLocalAccessorForKey(Object)} instead
*/
public boolean removeThreadLocalAccessor(String key) {
return removeThreadLocalAccessorForKey(key);
}

/**
* Removes a {@link ThreadLocalAccessor}.
* @param key under which the accessor got registered
* @return {@code true} when accessor got successfully removed
*/
public boolean removeThreadLocalAccessorForKey(Object key) {
for (ThreadLocalAccessor<?> existing : this.threadLocalAccessors) {
if (existing.key().equals(key)) {
return this.threadLocalAccessors.remove(existing);
Expand Down