-
Notifications
You must be signed in to change notification settings - Fork 76
Doc consistency #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc consistency #175
Conversation
This changeset enforces some style rules in the name of consistency: - All pages have a title - Bulleted lists use -, numbered use N. - Bulleted lists of links separated by linebreaks - One line-break before and after titles, lists and tables - All titles use markdown title syntax - Titles start with level 2, website uses h1 in header - Lists of links are always bulleted - Lead-in to lists ends with semi-colon These "rules" are somewhat arbitrary, but informed by the HTML rendered to the website and for ease of reading/editing.
1f2ee79
to
ac8b131
Compare
Rebased! I don't know what happened there, but it should be good to go now. I've made some educated assumptions about how my changes will affect the actual website- is there any way I can build the website locally to check I haven't broken anything? |
Thanks @Gadgetoid . I've given this a cursory review and looks good. I've also built it locally and can't see anything broken. let's merge and build to see if there are any issues in CI. I'll post a preview here when done. The developer site is closed source at present, so their isn't a way to build locally outside The Foundation |
Should eventually build at doc-consistency.review.tech.microbit.org.s3-website-eu-west-1.amazonaws.com Looks good to me as far as the content goes @Gadgetoid. What do you think? |
I haven't spotted any eggegious errors or breakage. I'm already seeing things I want to fix 😆 Chiefly:
|
7b0e132 Merge pull request #175 from Gadgetoid/doc-consistency ac8b131 Consistent use of whitespace and Markdown formatting 670d1f1 Remove hard linebreaks and trailing whitespace (#174) 6be457a update iOS beta instructions (#173) 1b2f2ec Update DAPLink error message (#171) 955cf1a spelling git-subtree-dir: docs git-subtree-split: 7b0e132
cc01c0f Latest updates for MakeCode and DAPLink (#193) 18ff8f7 Update hex-format.md: add missing space (#190) af73c3c Update apps-and-examples.md: add missing space (#189) 1f7d600 Spelling mistake (#186) b24c88f Re-phrasing bluetooth section (#181) 4007b76 Rephrase "lozenge" to "rounded rectangular" (#180) f8ca9aa Merge pull request #179 from Gadgetoid/spelling afe3441 Spelling and consistency tweaks 7b0e132 Merge pull request #175 from Gadgetoid/doc-consistency ac8b131 Consistent use of whitespace and Markdown formatting 670d1f1 Remove hard linebreaks and trailing whitespace (#174) 6be457a update iOS beta instructions (#173) 1b2f2ec Update DAPLink error message (#171) 955cf1a spelling git-subtree-dir: docs git-subtree-split: cc01c0f
* Squashed 'docs/' changes from ae437c7..21c6a16 21c6a16 update table 200mA > 190mA 9cffab0 Update info on MakeCode blocks cc01c0f Latest updates for MakeCode and DAPLink (#193) 18ff8f7 Update hex-format.md: add missing space (#190) af73c3c Update apps-and-examples.md: add missing space (#189) 1f7d600 Spelling mistake (#186) b24c88f Re-phrasing bluetooth section (#181) 4007b76 Rephrase "lozenge" to "rounded rectangular" (#180) f8ca9aa Merge pull request #179 from Gadgetoid/spelling afe3441 Spelling and consistency tweaks 7b0e132 Merge pull request #175 from Gadgetoid/doc-consistency ac8b131 Consistent use of whitespace and Markdown formatting 670d1f1 Remove hard linebreaks and trailing whitespace (#174) 6be457a update iOS beta instructions (#173) 1b2f2ec Update DAPLink error message (#171) 955cf1a spelling git-subtree-dir: docs git-subtree-split: 21c6a16 * Squashed 'docs/' changes from 21c6a16..ce75bb4 ce75bb4 remove duplicate MakeCode git-subtree-dir: docs git-subtree-split: ce75bb4 * Squashed 'docs/' changes from ce75bb4..3d3c6ed 3d3c6ed fix links 8260131 fix links 504c6df remove link to uhex spec as it 404s bee772f remove link to python mailing list git-subtree-dir: docs git-subtree-split: 3d3c6ed
3f33b0f add audio expression api 8ac53a3 update BLE profile roles 38464b4 Update Soft Device SD140 > SD113 (#198) 0f1b15d add new brand guidelines info 3d3c6ed fix links 8260131 fix links 504c6df remove link to uhex spec as it 404s bee772f remove link to python mailing list ce75bb4 remove duplicate MakeCode 21c6a16 update table 200mA > 190mA 9cffab0 Update info on MakeCode blocks cc01c0f Latest updates for MakeCode and DAPLink (#193) 18ff8f7 Update hex-format.md: add missing space (#190) af73c3c Update apps-and-examples.md: add missing space (#189) 1f7d600 Spelling mistake (#186) b24c88f Re-phrasing bluetooth section (#181) 4007b76 Rephrase "lozenge" to "rounded rectangular" (#180) f8ca9aa Merge pull request #179 from Gadgetoid/spelling afe3441 Spelling and consistency tweaks 7b0e132 Merge pull request #175 from Gadgetoid/doc-consistency ac8b131 Consistent use of whitespace and Markdown formatting 670d1f1 Remove hard linebreaks and trailing whitespace (#174) 6be457a update iOS beta instructions (#173) 1b2f2ec Update DAPLink error message (#171) 955cf1a spelling git-subtree-dir: docs git-subtree-split: 3f33b0f
cd87b61 Merge branch 'master' of https://github.com/microbit-foundation/dev-docs 3229f78 update feature availibility 9cf9964 Update latest-revision-main.md (#209) a7eb1ae Update edgeconnector.md: Fix badly rendered "V2" (#208) 6afa1e6 Correct spelling mistake (#210) 1af07f4 update CODAL info c72e636 Brand tidy up: v1 v2 > V1 V2 3f33b0f add audio expression api 8ac53a3 update BLE profile roles 38464b4 Update Soft Device SD140 > SD113 (#198) 0f1b15d add new brand guidelines info 3d3c6ed fix links 8260131 fix links 504c6df remove link to uhex spec as it 404s bee772f remove link to python mailing list ce75bb4 remove duplicate MakeCode 21c6a16 update table 200mA > 190mA 9cffab0 Update info on MakeCode blocks cc01c0f Latest updates for MakeCode and DAPLink (#193) 18ff8f7 Update hex-format.md: add missing space (#190) af73c3c Update apps-and-examples.md: add missing space (#189) 1f7d600 Spelling mistake (#186) b24c88f Re-phrasing bluetooth section (#181) 4007b76 Rephrase "lozenge" to "rounded rectangular" (#180) f8ca9aa Merge pull request #179 from Gadgetoid/spelling afe3441 Spelling and consistency tweaks 7b0e132 Merge pull request #175 from Gadgetoid/doc-consistency ac8b131 Consistent use of whitespace and Markdown formatting 670d1f1 Remove hard linebreaks and trailing whitespace (#174) 6be457a update iOS beta instructions (#173) 1b2f2ec Update DAPLink error message (#171) 955cf1a spelling git-subtree-dir: docs git-subtree-split: cd87b61
* Add template for universal hex tool * update uhex tool template * update nav * remove placeholder page * Squashed 'docs/' changes from ae437c7..09c6b6a 09c6b6a add details of uHex tool 652023b Update BLE services file location cd87b61 Merge branch 'master' of https://github.com/microbit-foundation/dev-docs 3229f78 update feature availibility 9cf9964 Update latest-revision-main.md (#209) a7eb1ae Update edgeconnector.md: Fix badly rendered "V2" (#208) 6afa1e6 Correct spelling mistake (#210) 1af07f4 update CODAL info c72e636 Brand tidy up: v1 v2 > V1 V2 3f33b0f add audio expression api 8ac53a3 update BLE profile roles 38464b4 Update Soft Device SD140 > SD113 (#198) 0f1b15d add new brand guidelines info 3d3c6ed fix links 8260131 fix links 504c6df remove link to uhex spec as it 404s bee772f remove link to python mailing list ce75bb4 remove duplicate MakeCode 21c6a16 update table 200mA > 190mA 9cffab0 Update info on MakeCode blocks cc01c0f Latest updates for MakeCode and DAPLink (#193) 18ff8f7 Update hex-format.md: add missing space (#190) af73c3c Update apps-and-examples.md: add missing space (#189) 1f7d600 Spelling mistake (#186) b24c88f Re-phrasing bluetooth section (#181) 4007b76 Rephrase "lozenge" to "rounded rectangular" (#180) f8ca9aa Merge pull request #179 from Gadgetoid/spelling afe3441 Spelling and consistency tweaks 7b0e132 Merge pull request #175 from Gadgetoid/doc-consistency ac8b131 Consistent use of whitespace and Markdown formatting 670d1f1 Remove hard linebreaks and trailing whitespace (#174) 6be457a update iOS beta instructions (#173) 1b2f2ec Update DAPLink error message (#171) 955cf1a spelling git-subtree-dir: docs git-subtree-split: 09c6b6a * Squashed 'docs/' changes from 09c6b6a..a1401e3 a1401e3 fix links git-subtree-dir: docs git-subtree-split: a1401e3 * Squashed 'docs/' changes from a1401e3..1d5265b 1d5265b add details of uHex tool (#213) f5464d9 Rewrite community page (#203) REVERT: a1401e3 fix links REVERT: 09c6b6a add details of uHex tool git-subtree-dir: docs git-subtree-split: 1d5265b * add newlines
* make newsletter more prominent * Squashed 'docs/' changes from ae437c7..4cb9286 4cb9286 add community buttons to index f14030c add error hex to hex tool page 3d71f9d Merge branch 'uhex-page' 854577a add hex format spec link 1d5265b add details of uHex tool (#213) a1401e3 fix links f5464d9 Rewrite community page (#203) 09c6b6a add details of uHex tool 652023b Update BLE services file location cd87b61 Merge branch 'master' of https://github.com/microbit-foundation/dev-docs 3229f78 update feature availibility 9cf9964 Update latest-revision-main.md (#209) a7eb1ae Update edgeconnector.md: Fix badly rendered "V2" (#208) 6afa1e6 Correct spelling mistake (#210) 1af07f4 update CODAL info c72e636 Brand tidy up: v1 v2 > V1 V2 3f33b0f add audio expression api 8ac53a3 update BLE profile roles 38464b4 Update Soft Device SD140 > SD113 (#198) 0f1b15d add new brand guidelines info 3d3c6ed fix links 8260131 fix links 504c6df remove link to uhex spec as it 404s bee772f remove link to python mailing list ce75bb4 remove duplicate MakeCode 21c6a16 update table 200mA > 190mA 9cffab0 Update info on MakeCode blocks cc01c0f Latest updates for MakeCode and DAPLink (#193) 18ff8f7 Update hex-format.md: add missing space (#190) af73c3c Update apps-and-examples.md: add missing space (#189) 1f7d600 Spelling mistake (#186) b24c88f Re-phrasing bluetooth section (#181) 4007b76 Rephrase "lozenge" to "rounded rectangular" (#180) f8ca9aa Merge pull request #179 from Gadgetoid/spelling afe3441 Spelling and consistency tweaks 7b0e132 Merge pull request #175 from Gadgetoid/doc-consistency ac8b131 Consistent use of whitespace and Markdown formatting 670d1f1 Remove hard linebreaks and trailing whitespace (#174) 6be457a update iOS beta instructions (#173) 1b2f2ec Update DAPLink error message (#171) 955cf1a spelling git-subtree-dir: docs git-subtree-split: 4cb9286 * add newsletter archive * Squashed 'docs/' changes from 4cb9286..4e786f5 4e786f5 add news archive c7ad57d Merge branch 'master' into nov2-sprint-updates 94aff4f update APIs and editors git-subtree-dir: docs git-subtree-split: 4e786f5 * Squashed 'docs/' changes from 4e786f5..faa62ab faa62ab update for Python release git-subtree-dir: docs git-subtree-split: faa62ab * Squashed 'docs/' changes from faa62ab..dbe04f9 dbe04f9 update for Python release 0a4aa2e add news archive d90d3ce add community buttons to index a55fe95 add error hex to hex tool page REVERT: faa62ab update for Python release REVERT: 4e786f5 add news archive REVERT: c7ad57d Merge branch 'master' into nov2-sprint-updates REVERT: 4cb9286 add community buttons to index REVERT: f14030c add error hex to hex tool page git-subtree-dir: docs git-subtree-split: dbe04f9 * Squashed 'docs/' changes from dbe04f9..677f242 677f242 Nov2 sprint updates (#226) c92dd07 Update latest-revision-main.md (#223) REVERT: dbe04f9 update for Python release REVERT: 0a4aa2e add news archive REVERT: d90d3ce add community buttons to index REVERT: a55fe95 add error hex to hex tool page git-subtree-dir: docs git-subtree-split: 677f242
a2fdb3c Ignore lancaster article (#246) 5eb4672 Update action.yml (#230) 6b0ecda change case for V2 button and table element ids (#236) 7201870 remove duplicate paragraph cc35817 update Mbed links 58fbba0 re-label new page 7649ddf remove Workbench ab22708 Update edgeconnector.md 16f1c90 fix links 677f242 Nov2 sprint updates (#226) c92dd07 Update latest-revision-main.md (#223) 94aff4f update APIs and editors 3d71f9d Merge branch 'uhex-page' 854577a add hex format spec link 1d5265b add details of uHex tool (#213) a1401e3 fix links f5464d9 Rewrite community page (#203) 09c6b6a add details of uHex tool 652023b Update BLE services file location cd87b61 Merge branch 'master' of https://github.com/microbit-foundation/dev-docs 3229f78 update feature availibility 9cf9964 Update latest-revision-main.md (#209) a7eb1ae Update edgeconnector.md: Fix badly rendered "V2" (#208) 6afa1e6 Correct spelling mistake (#210) 1af07f4 update CODAL info c72e636 Brand tidy up: v1 v2 > V1 V2 3f33b0f add audio expression api 8ac53a3 update BLE profile roles 38464b4 Update Soft Device SD140 > SD113 (#198) 0f1b15d add new brand guidelines info 3d3c6ed fix links 8260131 fix links 504c6df remove link to uhex spec as it 404s bee772f remove link to python mailing list ce75bb4 remove duplicate MakeCode 21c6a16 update table 200mA > 190mA 9cffab0 Update info on MakeCode blocks cc01c0f Latest updates for MakeCode and DAPLink (#193) 18ff8f7 Update hex-format.md: add missing space (#190) af73c3c Update apps-and-examples.md: add missing space (#189) 1f7d600 Spelling mistake (#186) b24c88f Re-phrasing bluetooth section (#181) 4007b76 Rephrase "lozenge" to "rounded rectangular" (#180) f8ca9aa Merge pull request #179 from Gadgetoid/spelling afe3441 Spelling and consistency tweaks 7b0e132 Merge pull request #175 from Gadgetoid/doc-consistency ac8b131 Consistent use of whitespace and Markdown formatting 670d1f1 Remove hard linebreaks and trailing whitespace (#174) 6be457a update iOS beta instructions (#173) 1b2f2ec Update DAPLink error message (#171) 955cf1a spelling git-subtree-dir: docs git-subtree-split: a2fdb3c
* Squashed 'docs/' changes from ae437c7..98a73dc 98a73dc Update index.md (#264) 6eddd17 Re-phrase making-accessories to be more direct (#205) 5bd2059 Minor updates to the pyOCD entry in "read flash" page (#249) 54a568d Add link to Android source code (#259) 91f9009 Fixed typo ba706cf Warn users blhost is advanced and unnecessary 9e3640f Update micropython.md (#257) 113df00 add other tested DAPlink versions a2fdb3c Ignore lancaster article (#246) 5eb4672 Update action.yml (#230) 6b0ecda change case for V2 button and table element ids (#236) 7201870 remove duplicate paragraph cc35817 update Mbed links 58fbba0 re-label new page 7649ddf remove Workbench ab22708 Update edgeconnector.md 16f1c90 fix links 677f242 Nov2 sprint updates (#226) c92dd07 Update latest-revision-main.md (#223) 94aff4f update APIs and editors 3d71f9d Merge branch 'uhex-page' 854577a add hex format spec link 1d5265b add details of uHex tool (#213) a1401e3 fix links f5464d9 Rewrite community page (#203) 09c6b6a add details of uHex tool 652023b Update BLE services file location cd87b61 Merge branch 'master' of https://github.com/microbit-foundation/dev-docs 3229f78 update feature availibility 9cf9964 Update latest-revision-main.md (#209) a7eb1ae Update edgeconnector.md: Fix badly rendered "V2" (#208) 6afa1e6 Correct spelling mistake (#210) 1af07f4 update CODAL info c72e636 Brand tidy up: v1 v2 > V1 V2 3f33b0f add audio expression api 8ac53a3 update BLE profile roles 38464b4 Update Soft Device SD140 > SD113 (#198) 0f1b15d add new brand guidelines info 3d3c6ed fix links 8260131 fix links 504c6df remove link to uhex spec as it 404s bee772f remove link to python mailing list ce75bb4 remove duplicate MakeCode 21c6a16 update table 200mA > 190mA 9cffab0 Update info on MakeCode blocks cc01c0f Latest updates for MakeCode and DAPLink (#193) 18ff8f7 Update hex-format.md: add missing space (#190) af73c3c Update apps-and-examples.md: add missing space (#189) 1f7d600 Spelling mistake (#186) b24c88f Re-phrasing bluetooth section (#181) 4007b76 Rephrase "lozenge" to "rounded rectangular" (#180) f8ca9aa Merge pull request #179 from Gadgetoid/spelling afe3441 Spelling and consistency tweaks 7b0e132 Merge pull request #175 from Gadgetoid/doc-consistency ac8b131 Consistent use of whitespace and Markdown formatting 670d1f1 Remove hard linebreaks and trailing whitespace (#174) 6be457a update iOS beta instructions (#173) 1b2f2ec Update DAPLink error message (#171) 955cf1a spelling git-subtree-dir: docs git-subtree-split: 98a73dc * Squashed 'docs/' changes from 98a73dc..94067ab 94067ab Update interface.md git-subtree-dir: docs git-subtree-split: 94067ab
❗ This changeset depends upon merging #174. The diff will be very big and noisy until #174 is merged.
This PR, #174 and others to follow aim to replace the mess in #170 with a series of documented commits that correct linebreaks, markdown consistency, spelling and - finally - rephrasing, in turn.
This changeset enforces some style rules in the name of consistency:
These "rules" are somewhat arbitrary, but informed by the HTML rendered to the website and for ease of reading/editing.
There are no typo fixes or re-wording in this PR- I will do a pass on typos once this and #174 are merged.
Titles
Pages without a lead-in title look weird, examples - https://tech.microbit.org/latest-revision/announcement/ and https://tech.microbit.org/bluetooth/apps-and-examples/ - since the top-margin is not equal to the left/right margins.
Since the page template steals the H1 tag, titles should ideally start at
## Title
which is H2. That said- the semantic meaning of H tags has been somewhat lost in the noise of the web. Pages seemed to start with/use one or the other, so I've erred on the side of technically correct and used H2+.I have replaced some
**strong**
titles with#### H4
titles without knowing if the site will correctly generate this markup. However I have confirmed that<h4>
does have appropriate CSS to be used in these cases- fingers crossed!Lists of links
Lists of links that are not bulleted tend to parse as sentences/paragraphs rather than individual, unrelated units. Adding bullets makes them clearly, intentional lists. Contrast the following:
To before:
Additionally, lists of links have been moved up the heading (and TOC-tree) heirachy to H2 and titled "Further information" (though this could be "More information" or otherwise) to clarify in the TOC exactly what type of links they are.