Refactor GHA workflows so build steps are decoupled from deployment step #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eecavanna
deleted the
176-decouple-build-and-publish-jobs-into-different-gha-workflows-to-enable-granular-reuse
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On this branch, I removed the
buildjob from thedeploy-to-gh-pages.ymlworkflow and put it in a new workflow, calledassemble-website.yml. This will make it so other workflows can trigger a build without also triggering a deployment.I also removed some workflow triggers from workflows that will be triggered as dependencies anyway. In other words, if A depends upon B, and A is configured to run whenever someone commits to
main, GitHub will take care of running B in that situation for me.