Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature decouple somd #13

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Feature decouple somd #13

wants to merge 3 commits into from

Conversation

Roy-Haolin-Du
Copy link

This PR includes the following changes:

Refactored SystemPreparationConfig into the configuration module.
Added and updated SlurmConfig for better modularity.
Updated and passed all relevant pytest cases.
ruff format and check for standard files format

@Roy-Haolin-Du Roy-Haolin-Du requested a review from fjclark December 4, 2024 11:18
@fjclark fjclark self-assigned this Dec 4, 2024
@fjclark fjclark added the enhancement New feature or request label Dec 4, 2024
a3fe/_version.py Outdated
@@ -1 +1 @@
__version__ = "0.2.0"
__version__ = "0.1.3+22.ga2a8eb5.dirty"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file gets automatically updated according to the git tag. You can list git tags with git tag -l. 0.2.0 should be the most recent one - if it's not, please pull changes from the main branch.

As this gets auto-updated and isn't a deliberate code change, please revert this change. Thanks!

@fjclark
Copy link
Collaborator

fjclark commented Dec 4, 2024

Hi Roy. Thanks very much for this!

I've cancelled the CI for the moment as there are a few changes it would be good to make before running all the tests.

It's a bit hard to see the relevant changes because there are 204 files changed. Most of these are in the data directory. Please could you revert all changes to the a3fe/data directory? These files aren't related to this PR and shouldn't be changed. After that I'll have a closer look at your changes.

Thanks!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes aren't directly related to this PR, so please revert them.

We should probably make the plotting more flexible so you don't have to make manual changes like this, but let's save this for another PR! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants