-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature decouple somd #13
base: main
Are you sure you want to change the base?
Conversation
a3fe/_version.py
Outdated
@@ -1 +1 @@ | |||
__version__ = "0.2.0" | |||
__version__ = "0.1.3+22.ga2a8eb5.dirty" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file gets automatically updated according to the git tag. You can list git tags with git tag -l
. 0.2.0 should be the most recent one - if it's not, please pull changes from the main branch.
As this gets auto-updated and isn't a deliberate code change, please revert this change. Thanks!
Hi Roy. Thanks very much for this! I've cancelled the CI for the moment as there are a few changes it would be good to make before running all the tests. It's a bit hard to see the relevant changes because there are 204 files changed. Most of these are in the Thanks! |
a3fe/analyse/plot.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes aren't directly related to this PR, so please revert them.
We should probably make the plotting more flexible so you don't have to make manual changes like this, but let's save this for another PR! Thanks.
This PR includes the following changes:
Refactored SystemPreparationConfig into the configuration module.
Added and updated SlurmConfig for better modularity.
Updated and passed all relevant pytest cases.
ruff format and check for standard files format