Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German language definition #3

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Conversation

joshi-monster
Copy link
Contributor

Also joining in adding languages! 💜

@joshi-monster
Copy link
Contributor Author

joshi-monster commented Jul 7, 2024

Also I just noticed that the language definitions could be constants as well, as long as we keep adding top-level functions. Should they?

@michaeljones michaeljones self-assigned this Jul 8, 2024
@michaeljones michaeljones merged commit b4b1ea7 into michaeljones:main Jul 8, 2024
1 check passed
@michaeljones
Copy link
Owner

Thanks for the contribution! Cool to see!

Also I just noticed that the language definitions could be constants as well, as long as we keep adding top-level functions. Should they?

Sounds like a good plan. I don't have much experience with constants in Gleam yet but I image it is a fairly trivial change. I can try to do it or I'd welcome a PR if you'd like to do one.

@michaeljones
Copy link
Owner

Released in 0.4.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants