Build warning reduction#363
Open
GreyGrisGrey wants to merge 10 commits into
Open
Conversation
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
Bot
added
Changes: UI
and removed
S: Needs Review
size/M
S: Merge Conflict
labels
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Broad codebase updates to deal with build problems. Reduction should be from ~11k problems to 28.
Technical details
Changed ~10.5k lines of code to eliminate build problems caused by the recent Robust Toolbox update.
Removed maybe 20 instances of obsolete function usage.
Suppressed obsolete function warnings due to their presence in the Robust Toolbox itself.
Removed a few build problems manually.
Removed a few integration test files containing tests extremely reliant on obsolete functions on the basis that they likely are part of the problem with the integration tests.
Requirements