Open
Conversation
Also, remove typeclass constraint on `free` since it is unnecessary and enables typechecking
Owner
Author
|
I didn't mean for this PR to be carrying along several old commits... I will update this one later (Don't merge!) |
Collaborator
|
Thanks for submitting it! A good way to mark a PR as WIP is to use Github's Draft PR feature: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-stage-of-a-pull-request#converting-a-pull-request-to-a-draft |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing cilksort segfaults and slowness by porting the optimizations to parallel mergesort (I think it's mainly the recursive helper function and the {-# INLINE #-} )
Haven't seriously benchmarked, but seems slightly faster than parallel mergesort because of the fallback to (seq) quicksort instead of sequential mergesort. On 10 million items: