Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Appease mypy for arithmetic #510

Merged
merged 3 commits into from
Oct 14, 2023
Merged

Appease mypy for arithmetic #510

merged 3 commits into from
Oct 14, 2023

Commits on Oct 2, 2023

  1. Appease type checking for arithmetic using Python operators 

    #486
    @mhostetter
    mhostetter committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    56a79b2 View commit details
    Browse the repository at this point in the history

  2. Add more detailed arithmetic type annotations

    @mhostetter
    mhostetter committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    48b54c5 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2023

  1. Remove other: Self type annotation 

    If `Self + NDArray` is performed, this prevents `mypy` from falling back to `ndarray.__radd__()`, which has a return type of `NDArray`. This ensures that the arithmetic type is always `Self`. The runtime type checking will ensure valid arguments are passed.
    @mhostetter
    mhostetter committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    0ecb4cb View commit details
    Browse the repository at this point in the history