Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update imports.yml #3984

Merged
merged 7 commits into from
May 24, 2024
Merged

Update imports.yml #3984

merged 7 commits into from
May 24, 2024

Conversation

sbello
Copy link
Contributor

@sbello sbello commented May 23, 2024

removed line
container: obolibrary/odkfull:v1.4

Import action runs, primary concern is the massive change to the patterns

@sbello sbello requested a review from matentzn May 23, 2024 14:50
Added back in     container: obolibrary/odkfull:v1.4
@sbello
Copy link
Contributor Author

sbello commented May 23, 2024

@matentzn with the container line back in place the imports action again fails with the error

Run cd src/ontology/ && docker run -v $PWD/../../:/work -w /work/src/ontology -e ROBOT_JAVA_ARGS='-Xmx10G' -e JAVA_OPTS='-Xmx10G' --rm obolibrary/odklite make GITHUB_ACTION=true refresh-imports
/__w/_temp/ea4c4a23-56d7-4bc5-9081-faca4ab25dfe.sh: 1: docker: not found
Error: Process completed with exit code 127.

@matentzn
Copy link
Collaborator

Yes, check how the command works in PATO, it should start with "make" not "docker xyz". If you have trouble I will change it tomorrow, just let me know if you didn't make it!

sbello and others added 4 commits May 23, 2024 15:58
changed the import line to make
changing all steps to make rather than docker xyz
@sbello
Copy link
Contributor Author

sbello commented May 23, 2024

Made the changes, import action now runs but the deploy has the same issue that the import action had so I can't currently check that the import action is fully functioning as desired. The import changes look similar to old changes.

I will try to update the deploy as I did for the imports.

@@ -27,7 +23,7 @@ jobs:
run: echo "::set-output name=date::$(date +'%Y-%m-%d')"

- name: Update release files
run: cd src/ontology/ && docker run -v $PWD/../../:/work -w /work/src/ontology -e ROBOT_JAVA_ARGS='-Xmx10G' -e JAVA_OPTS='-Xmx10G' --rm obolibrary/odkfull make GITHUB_ACTION=true prepare_release_fast
run: cd src/ontology/ && make ROBOT_ENV='ROBOT_JAVA_ARGS=-Xmx10G' GITHUB_ACTION=true prepare_release_fast
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anitacaron do you understand why it says

ROBOT_ENV='ROBOT_JAVA_ARGS=-Xmx10G'

instead of

ROBOT_JAVA_ARGS=-Xmx10G

? I can see this also exists in other pipelines but I cannot remember putting this anywhere.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember this either. I've checked the commit history and couldn't find anything.

@sbello sbello merged commit 6db3a44 into main May 24, 2024
2 checks passed
@sbello sbello deleted the sbello-patch-1 branch May 24, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants