-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update imports.yml #3984
Update imports.yml #3984
Conversation
Added back in container: obolibrary/odkfull:v1.4
@matentzn with the container line back in place the imports action again fails with the error Run cd src/ontology/ && docker run -v $PWD/../../:/work -w /work/src/ontology -e ROBOT_JAVA_ARGS='-Xmx10G' -e JAVA_OPTS='-Xmx10G' --rm obolibrary/odklite make GITHUB_ACTION=true refresh-imports |
Yes, check how the command works in PATO, it should start with "make" not "docker xyz". If you have trouble I will change it tomorrow, just let me know if you didn't make it! |
changed the import line to make
changing all steps to make rather than docker xyz
Update all imports and components
Made the changes, import action now runs but the deploy has the same issue that the import action had so I can't currently check that the import action is fully functioning as desired. The import changes look similar to old changes. I will try to update the deploy as I did for the imports. |
@@ -27,7 +23,7 @@ jobs: | |||
run: echo "::set-output name=date::$(date +'%Y-%m-%d')" | |||
|
|||
- name: Update release files | |||
run: cd src/ontology/ && docker run -v $PWD/../../:/work -w /work/src/ontology -e ROBOT_JAVA_ARGS='-Xmx10G' -e JAVA_OPTS='-Xmx10G' --rm obolibrary/odkfull make GITHUB_ACTION=true prepare_release_fast | |||
run: cd src/ontology/ && make ROBOT_ENV='ROBOT_JAVA_ARGS=-Xmx10G' GITHUB_ACTION=true prepare_release_fast |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anitacaron do you understand why it says
ROBOT_ENV='ROBOT_JAVA_ARGS=-Xmx10G'
instead of
ROBOT_JAVA_ARGS=-Xmx10G
? I can see this also exists in other pipelines but I cannot remember putting this anywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember this either. I've checked the commit history and couldn't find anything.
removed line
container: obolibrary/odkfull:v1.4
Import action runs, primary concern is the massive change to the patterns