refactor: simplify File.disabledIntervals, add tests #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chavacava
reviewed
Feb 14, 2025
|
Hi @alexandear, thank you for the PR. I left a comment, let me know what do you think. (the PR can be merged as is but I'll wait for your response a couple of days) |
@chavacava thank you for the review. I have fixed the comments by adding a utility function. Please re-check. Sorry for the late response. |
alexandear
force-pushed
the
refactor/file-disabled-intervals
branch
from
d88e416 to
b421056
Compare
alexandear
force-pushed
the
refactor/file-disabled-intervals
branch
from
b421056 to
19b55aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR performs some refactoring for the function
File.disabledIntervalsand add basic tests to cover most common cases.