Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify File.disabledIntervals, add tests #1216

Merged

Conversation

alexandear
Copy link
Contributor

This PR performs some refactoring for the function File.disabledIntervals and add basic tests to cover most common cases.

@chavacava
Copy link
Collaborator

Hi @alexandear, thank you for the PR. I left a comment, let me know what do you think. (the PR can be merged as is but I'll wait for your response a couple of days)

@alexandear
Copy link
Contributor Author

Hi @alexandear, thank you for the PR. I left a comment, let me know what do you think. (the PR can be merged as is but I'll wait for your response a couple of days)

@chavacava thank you for the review. I have fixed the comments by adding a utility function. Please re-check.

Sorry for the late response.

@alexandear alexandear force-pushed the refactor/file-disabled-intervals branch from d88e416 to b421056 Compare February 18, 2025 17:37
@alexandear alexandear force-pushed the refactor/file-disabled-intervals branch from b421056 to 19b55aa Compare February 18, 2025 17:37
@alexandear alexandear requested a review from chavacava February 18, 2025 17:38
@chavacava chavacava merged commit 6d0498c into mgechev:master Mar 7, 2025
7 checks passed
@alexandear alexandear deleted the refactor/file-disabled-intervals branch March 7, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants