Skip to content

fix: add embedding_api.base_url to /health response (closes #36) - #42

Merged
mfethe1 merged 1 commit into
mainfrom
fix/issue-36-health-embedding-status
May 6, 2026
Merged

fix: add embedding_api.base_url to /health response (closes #36)#42
mfethe1 merged 1 commit into
mainfrom
fix/issue-36-health-embedding-status

Conversation

@mfethe1

@mfethe1 mfethe1 commented May 6, 2026

Copy link
Copy Markdown
Owner

Closes #36

Main already has graceful embedding degradation in all paths (embeddings_client.py returns None on any failure, create_memory and /search both handle None embedding). This PR adds the one missing piece: the embedding_api.base_url field in GET /health so operators can see the configured embedding endpoint at a glance.

Before:

{"status": "healthy", "version": "0.1.0"}

After:

{"status": "healthy", "version": "0.1.0", "embedding_api": {"base_url": "http://..."}}

Supersedes #39 (which targeted a diverged branch).

Main already handles None-embedding gracefully in create_memory and
search paths (embeddings_client returns None on failure). This adds
the embedding_api field to /health so operators can see the configured
base URL at a glance.
@mfethe1
mfethe1 merged commit c92d91d into main May 6, 2026
@mfethe1
mfethe1 deleted the fix/issue-36-health-embedding-status branch May 6, 2026 17:37
@chatgpt-codex-connector

Copy link
Copy Markdown

💡 Codex Review

"embedding_api": {"base_url": resolve_embedding_api_base()},

P2 Badge Redact the health endpoint base URL

Because /health is unauthenticated and intended for external probes, returning the raw EMBEDDING_API_BASE/EMBEDDING_BASE_URL value here can expose deployment details, and it can leak credentials if a custom embedding endpoint is configured with URL userinfo such as https://user:pass@host. Consider redacting credentials (or exposing only host/scheme) before including this operator-facing field.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: graceful degradation when embedding API host is unreachable

1 participant