RequireJS Support and Misc Improvements#9
Open
mjhasbach wants to merge 4 commits intomezzoblue:masterfrom
Open
RequireJS Support and Misc Improvements#9mjhasbach wants to merge 4 commits intomezzoblue:masterfrom
mjhasbach wants to merge 4 commits intomezzoblue:masterfrom
Conversation
|
Love that last point. I hope that I'm now able to update certain DOM-Elements without recoloring the others. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
initmethod on thepaintBrushobject which callsaddLoadEventand executespaintBrush.processFiltersin the callback. In my opinion, the developers who leverage this library should be able to decide when filters are processed.If you like this PR, I will write some documentation on how to configure PaintbrushJS as a RequireJS package.