Upgraded to php8.1

mettle · Feb 8, 2022 · 274f041 · 274f041
1 parent df7d6fa
commit 274f041
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml
@@ -7,7 +7,7 @@ on:
       - "master"
 
 env:
-  COMPOSER_ROOT_VERSION: "1.99.99"
+  COMPOSER_ROOT_VERSION: "2.99.99"
 
 jobs:
 
@@ -22,6 +22,7 @@ jobs:
           - "7.3"
           - "7.4"
           - "8.0"
+          - "8.1"
     steps:
       - uses: "actions/checkout@v2"
       - uses: "shivammathur/setup-php@v2"

diff --git a/composer.json b/composer.json
@@ -2,8 +2,8 @@
   "name": "mettle/oauth2-adobe-sign",
   "description": "Adobe Sign OAuth 2.0 Client Provider for The PHP League OAuth2-Client",
   "require": {
-    "php": "^7.3 || ^8.0",
-    "league/oauth2-client": "^2.5"
+    "php": "^7.3 || ^8.0 || ^8.1",
+    "league/oauth2-client": "^2.5",
   },
   "require-dev": {
     "phpunit/phpunit": "^9.0",

diff --git a/src/AdobeSign.php b/src/AdobeSign.php
@@ -108,6 +108,8 @@ public function getBaseRevokeTokenUrl()
     public function getResourceOwnerDetailsUrl(AccessToken $token)
     {
         // TODO: Implement getResourceOwnerDetailsUrl() method.
+        // PHP8.1 complains about null being passed into the stack.
+        return '';
     }
 
     /**

diff --git a/tests/AdobeSignTest.php b/tests/AdobeSignTest.php
@@ -119,7 +119,7 @@ public function testGetResourceOwnerDetailsUrl()
     {
         $accessToken = m::mock('League\OAuth2\Client\Token\AccessToken');
         $res = $this->provider->getResourceOwnerDetailsUrl($accessToken);
-        $this->assertNull($res);
+        $this->assertEmpty($res);
     }
 
     public function testCreateResourceOwner()