Initialize Self to null pointer to use with std::make_shared#1329
Merged
Initialize Self to null pointer to use with std::make_shared#1329
Conversation
kyleam
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AFAIK,
evt::regimenis working fine. However, I just discovered that I can't make a shared pointer for this object (std::shared_ptr()) because of the way the object is initialized. Recall that we have to do some of these gymnastics because the objects need to be declared outside of any function so they are global to the model translation unit. And, because we need to "refresh" the object with every individual, we just declare the object and then writeinit()orreset()methods to refresh.I found that initializing
*Selftonullptrallows us to successfully make the shared pointer. I don't know of a way to test this, so I'm just putting it out there and letting the existing tests handle it.