add show_labels function#63
Conversation
R/RcppExports.R
Outdated
| #' @param x A numeric vector of values | ||
| #' @param left,right Boundary values | ||
| #' @noRd | ||
| #' @export |
There was a problem hiding this comment.
Was this intentional? If not, can we revert this and rerun document to revert the Rd files impacted by this?
There was a problem hiding this comment.
Not intentional. I have reverted this, along with the Rd and NAMESPACE files.
There was a problem hiding this comment.
@michaelmcd18 I notice now that the top of R/RcppExports.R has this comment:
# Generated by using Rcpp::compileAttributes() -> do not edit by hand
Running Rcpp::compileAttributes() makes this same edit again. I'm not familiar with Rcpp, and I'm not sure how to resolve.
There was a problem hiding this comment.
I think maybe src/set_bins.cpp and src/auc_p.cpp should each have //' @keywords internal set for the set_bins_cpp and auc_partial_cpp functions respectively (assuming these functions are not meant to be exported by mrgmisc). Does that sound reasonable?
There was a problem hiding this comment.
@toddyoder-mrg Agreed on the solution, we don't want either of those exported
There was a problem hiding this comment.
@michaelmcd18 thanks. I've added //' @keywords internal to both functions and rebuilt the documentation. The CI checks pass now.
| fs, | ||
| withr | ||
| withr, | ||
| tidyselect |
There was a problem hiding this comment.
Can you please iterate the package version to 0.3.0.9002 and include yourself as one of the authors of the package @toddyoder-mrg
R/show_labels.R
Outdated
| # return | ||
| tibble::tibble( | ||
| name = names(df_meta), | ||
| label = stats::setNames(labels, NULL) |
There was a problem hiding this comment.
I think this works if you just did label = labels
michaelmcd18
left a comment
michaelmcd18
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for making all the updates @toddyoder-mrg
2 participants
New function to view the labels of a data.frame.
Also reran
devtools::document()which updated some man files for existing functions.