Use only basename when forming stem from script and tag#53
Merged
Conversation
Contributor
Author
|
@KatherineKayMRG heads up. |
kyleam
approved these changes
Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See example in #52
There's a feature where you can set a context and save a series of plots using a combination of the context name and a "tag" that is supplied with each plot.
The default "context" is the name of the script, but you can override that through an option.
This was causing a problem when we started passing in the full path to the script:
This PR just takes the
basename()ofscriptprior to starting this whole process off to ensure we don't get a path to output file that we didn't intend.The change here is only meant to preserve existing behavior, which was expecting
scriptto be just the name of the script.