Skip to content

Comments

ci: update ubuntu-20.04 jobs to ubuntu-22.04#51

Merged
kyleam merged 2 commits intomainfrom
ci-update-os
Feb 12, 2025
Merged

ci: update ubuntu-20.04 jobs to ubuntu-22.04#51
kyleam merged 2 commits intomainfrom
ci-update-os

Conversation

@kyleam
Copy link
Contributor

@kyleam kyleam commented Feb 12, 2025

The ubuntu-20.04 image is deprecated as of 2025-02-01 and is scheduled to be retired on 2025-04-01.

https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions

The ubuntu-20.04 image is deprecated as of 2025-02-01 and is scheduled
to be retired on 2025-04-01.

https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions
@kyleam
Copy link
Contributor Author

kyleam commented Feb 12, 2025

@kyleam kyleam marked this pull request as draft February 12, 2025 17:36
With the ubuntu-20.04 to ubuntu-22.04 update, the R 3.6.3 job fails to
build testthat:

  ../inst/include/testthat/vendor/catch.h:6490:33: error: size of array ‘altStackMem’ is not an integral constant-expression
   6490 |         static char altStackMem[SIGSTKSZ];
        |                                 ^~~~~~~~
  ../inst/include/testthat/vendor/catch.h:6541:45: error: size of array ‘altStackMem’ is not an integral constant-expression
   6541 |     char FatalConditionHandler::altStackMem[SIGSTKSZ] = {};
        |                                             ^~~~~~~~
  make: *** [/opt/R/3.6.3/lib/R/etc/Makeconf:177: test-runner.o] Error 1
  ERROR: compilation failed for package ‘testthat’

The R 3.6.3 job uses an old version of testthat due to hitting a waldo
error ("object 'compare_proxy' not found"), but, trying now with the
latest version of testthat (3.2.1.1), this failure no longer occurs.

So side step the above error by unpinning testthat.
@kyleam kyleam marked this pull request as ready for review February 12, 2025 19:48
@kyleam kyleam requested a review from kylebaron February 12, 2025 19:48
@kyleam kyleam merged commit 8c967f9 into main Feb 12, 2025
7 checks passed
@kyleam kyleam deleted the ci-update-os branch February 12, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants