Max Updates: by BaseMax · Pull Request #126 · metropolis-retro/metropolis-retro.github.io

BaseMax · 2026-05-02T16:26:08Z

Updates

vercel · 2026-05-02T16:26:13Z

@BaseMax is attempting to deploy a commit to the retro Team on Vercel.

A member of the Team first needs to authorize it.

gemini-code-assist

Code Review

This pull request introduces a .gitattributes file to ensure consistent line-ending normalization across various text file formats and to define binary file types. The review feedback suggests treating SVG files as text to enable meaningful diffs and adding an explicit binary declaration for Bun's bun.lockb lockfile.

github-advanced-security · 2026-05-02T16:56:47Z

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

jbampton · 2026-05-02T17:35:55Z

/gemini review

gemini-code-assist

Code Review

This pull request establishes a testing foundation using Bun, adding snapshot tests for various UI components including Badge, Button, Card, Input, Label, Separator, and Skeleton. It also enhances project configuration with updated .dockerignore and .gitattributes files, integrates a spell-checking hook in the pre-commit configuration, and adds a YouTube icon to the footer. Feedback focuses on resolving an inconsistency in the README regarding committed files, adopting the standard Bun flag for snapshot updates in package.json, and ensuring test cases for custom classes use unique values to avoid redundancy.

Copilot

Pull request overview

This PR adds Bun-based snapshot testing for UI components and strengthens repository automation/tooling (prek workflows, CodeQL, first-interaction messaging), alongside Docker and repo hygiene updates.

Changes:

Add Bun snapshot tests for several UI components plus committed snapshot baselines, and wire up bun test scripts/workflow.
Refactor prek GitHub Actions into reusable workflows and adjust workflow permissions.
Add repo hygiene + UX updates: .gitattributes, .dockerignore, Dockerfile dev lockfile enforcement, first-interaction message refresh, and a YouTube social link/icon.

Reviewed changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tests/components/ui/skeleton.test.tsx	Adds Bun snapshot tests for `Skeleton`.
tests/components/ui/separator.test.tsx	Adds Bun snapshot tests for `Separator`.
tests/components/ui/label.test.tsx	Adds Bun snapshot tests for `Label`.
tests/components/ui/input.test.tsx	Adds Bun snapshot tests for `Input`.
tests/components/ui/card.test.tsx	Adds Bun snapshot tests for `Card` and subcomponents.
tests/components/ui/button.test.tsx	Adds Bun snapshot tests for `Button` variants/sizes.
tests/components/ui/badge.test.tsx	Adds Bun snapshot tests for `Badge` variants.
tests/components/ui/snapshots/skeleton.test.tsx.snap	Commits snapshot baselines for `Skeleton` tests.
tests/components/ui/snapshots/separator.test.tsx.snap	Commits snapshot baselines for `Separator` tests.
tests/components/ui/snapshots/label.test.tsx.snap	Commits snapshot baselines for `Label` tests.
tests/components/ui/snapshots/input.test.tsx.snap	Commits snapshot baselines for `Input` tests.
tests/components/ui/snapshots/card.test.tsx.snap	Commits snapshot baselines for `Card` tests.
tests/components/ui/snapshots/button.test.tsx.snap	Commits snapshot baselines for `Button` tests.
tests/components/ui/snapshots/badge.test.tsx.snap	Commits snapshot baselines for `Badge` tests.
package.json	Adds `test`, `test:watch`, and `test:update` scripts using Bun.
bunfig.toml	Configures Bun test root under `./tests`.
.github/workflows/snapshot-tests.yml	Adds CI workflow to run Bun snapshot tests.
.github/workflows/reusable-prek-standard.yml	Introduces reusable workflow for standard prek hooks.
.github/workflows/reusable-prek-manual.yml	Introduces reusable workflow for manual prek hooks.
.github/workflows/pre-commit.yml	Switches standard prek CI to reusable workflows across OS matrix.
.github/workflows/pre-commit-manual.yml	Switches manual prek CI to reusable workflows on macOS/Ubuntu.
.github/workflows/codeql.yml	Adds CodeQL analysis workflow for JS/TS.
.github/workflows/first-interaction.yml	Updates first-interaction workflow permissions and welcome messages.
.pre-commit-config.yaml	Adds `typos` pre-commit hook.
Dockerfile.dev	Uses `bun install --frozen-lockfile` for deterministic installs.
.dockerignore	Adds dockerignore rules to reduce build context and avoid copying secrets/artifacts.
.gitattributes	Adds line-ending normalization and binary file declarations.
components/icons/brand-social-icons.tsx	Adds `BrandYouTubeIcon`.
components/layout/footer.tsx	Adds YouTube social link to footer.
README.md	Documents generated files/paths and snapshot guidance.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

jbampton · 2026-05-02T17:53:15Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces a comprehensive testing suite using Bun snapshots for several UI components, including Badge, Button, Card, Input, Label, Separator, and Skeleton. It also updates project configuration files such as .dockerignore, .gitattributes, and .pre-commit-config.yaml (adding a typos checker), and adds a YouTube social icon to the footer. Feedback focuses on maintaining consistency between the README documentation and package.json scripts, as well as ensuring uniform URL formats for social media links.

Copilot

Pull request overview

Copilot reviewed 30 out of 30 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

BaseMax · 2026-05-02T18:45:56Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces a comprehensive testing suite using Bun's snapshot testing for various UI components, adds a spell-checking pre-commit hook, and improves Docker build determinism with the --frozen-lockfile flag. It also adds a YouTube social icon and documents auto-generated paths in the README. Feedback suggests enhancing consistency by removing redundant package-lock.json files and standardizing on Bun for sub-project builds currently using npm.

BaseMax · 2026-05-03T06:23:06Z

We did /gemini review three times, all good so far.

BaseMax · 2026-05-22T11:02:04Z

@copilot resolve the merge conflicts in this pull request

jbampton · 2026-06-27T13:44:19Z

Pull requested need to be focused on only one issue.

This PR has way to many different things all mixed together.

This PR has been sitting here with conflicts for a long time.

You need to create small self contained PRs that are easy to review.

I appreciate the efforts but you need to follow the proper rules and procedures

Adding git attributes file

1889d63

BaseMax self-assigned this May 2, 2026

BaseMax requested a review from jbampton as a code owner May 2, 2026 16:26

This was referenced May 2, 2026

Add .gitattributes file #52

Closed

Super-Linter: GitHub Actions zizmor has "warn" level message #22

Open

gemini-code-assist Bot reviewed May 2, 2026

View reviewed changes

Comment thread .gitattributes Resolved

Comment thread .gitattributes Resolved

BaseMax added 4 commits May 2, 2026 19:29

Update first-interaction.yml

d43aea3

Add bun tests

b3ac6bb

Adding crate-ci/typos into pre-commit

65d19eb

Ignore generated __snapshots__ dir inside tests/components/ui/

0438e39

This was referenced May 2, 2026

Setup snapshot testing with Bun #46

Open

Add rust typos crate with pre-commit #57

Open

Need a list of all files / paths where files are generated SalamLang/Salam#1171

Open

BaseMax added 4 commits May 2, 2026 19:44

Adding Generated Files & Paths section in readme

ef8459a

Update gitattributes file

0f2f027

Update github workflows

2ce9703

Adding youtube icon

7315381

Add snapshot snap tsx files

21bb816

jbampton requested a review from Copilot May 2, 2026 17:36

jbampton added this to METROPOLIS May 2, 2026

github-project-automation Bot moved this to Backlog in METROPOLIS May 2, 2026

jbampton added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed hacktoberfest labels May 2, 2026

Copilot started reviewing on behalf of jbampton May 2, 2026 17:36

View session

jbampton moved this from Backlog to In progress in METROPOLIS May 2, 2026

gemini-code-assist Bot reviewed May 2, 2026

View reviewed changes

Comment thread README.md Resolved

Comment thread package.json Resolved

Comment thread tests/components/ui/input.test.tsx Resolved

Copilot AI reviewed May 2, 2026

View reviewed changes

Comment thread .github/workflows/reusable-prek-manual.yml Resolved

Comment thread README.md Resolved

Comment thread README.md Resolved

jbampton requested changes May 2, 2026

View reviewed changes

Comment thread .dockerignore Resolved

updates

0678c79

jbampton requested a review from Copilot May 2, 2026 17:53

Copilot started reviewing on behalf of jbampton May 2, 2026 17:53

View session

gemini-code-assist Bot reviewed May 2, 2026

View reviewed changes

Comment thread components/layout/footer.tsx Resolved

Comment thread README.md Resolved

Copilot AI reviewed May 2, 2026

View reviewed changes

Comment thread .dockerignore Resolved

Comment thread .github/workflows/pre-commit.yml Resolved

Comment thread .github/workflows/pre-commit-manual.yml Resolved

Comment thread README.md Resolved

BaseMax and others added 3 commits May 2, 2026 21:32

Potential fix for pull request finding

cbfeda8

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Update README.md

cd6504a

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update readme and update pre-commit.yml and pre-commit-manual.yml

214912f

gemini-code-assist Bot reviewed May 2, 2026

View reviewed changes

Comment thread .dockerignore Resolved

Comment thread README.md Resolved

BaseMax added 7 commits May 2, 2026 21:56

update yml and readme to fix lint errors

f1411ce

up

7f1c87c

Run and fix errors from prek

4bc059d

update first interaction

8a38559

update codespell.txt

fb4e953

update super linter - lines

db80f9e

add write permissions

a6d6c60

jbampton closed this Jun 27, 2026

github-project-automation Bot moved this from In progress to Done in METROPOLIS Jun 27, 2026

Conversation

BaseMax commented May 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Updates

Uh oh!

vercel Bot commented May 2, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

github-advanced-security AI commented May 2, 2026

What Enabling Code Scanning Means:

Uh oh!

jbampton commented May 2, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jbampton commented May 2, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BaseMax commented May 2, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

BaseMax commented May 3, 2026

Uh oh!

BaseMax commented May 22, 2026

Uh oh!

jbampton commented Jun 27, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

BaseMax commented May 2, 2026 •

edited

Loading