MET-4365: New initialization - #92
Merged
Merged
Conversation
AKajt
requested review from
anto-metica,
antonurankar-moloco and
rstecca-metica
September 26, 2025 15:52
| public static async Task<bool> InitializeAsync(MeticaConfiguration configuration) | ||
| { | ||
| return await PlatformDelegate.InitializeAsync(MeticaSdk.ApiKey, MeticaSdk.AppId, MeticaSdk.CurrentUserId, MeticaSdk.Version, MeticaSdk.BaseEndpoint, configuration); | ||
| MeticaAdsInitializationResult result = await PlatformDelegate.InitializeAsync( |
Contributor
There was a problem hiding this comment.
This function could call InitializeWithResultAsync as that should give you all the info needed for the boolean.
| } | ||
| } | ||
|
|
||
| private MeticaAdsAssignmentStatus Status { get; } |
Contributor
There was a problem hiding this comment.
By having this private, consumer cannot access it. You in essence created the same API where pub can only get isMeticaAdsEnabled
Contributor
There was a problem hiding this comment.
Also even when you make this public, having two APIs to access the same thing like
Status == MeticaAdsAssignmentStatus.Normal and its helper isMeticaAdsEnabled breads only confusion
Contributor
Author
There was a problem hiding this comment.
Yeah I had this fixed but didn't push it.
…tialization status
antonurankar-moloco
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the Metica Unity SDK to version 1.13.4 and introduces a more robust initialization flow for Metica Ads, allowing clients to determine the assignment status and whether ads are enabled. The changes include new result and status types for initialization, updates to platform delegates, and improvements to the Android callback interface.