chore(mts): odds and ends #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luthaf
reviewed
Oct 27, 2025
| /// The caller must ensure that the returned pointer does not outlive | ||
| /// this `DLPackTensor` wrapper. The caller must not call the `deleter` | ||
| /// function on this pointer, as the wrapper will do so on drop. | ||
| pub fn as_mut_ptr(&self) -> *mut sys::DLManagedTensorVersioned { |
There was a problem hiding this comment.
this is very unsound =) It should at least take &mut self, otherwise one could get two mut pointers to the same underlying data, but I'd prefer having this function return a &mut sys::DLManagedTensorVersioned instead, so we get full lifetime tracking.
There was a problem hiding this comment.
Also, I'm not sure what's the use case is. If we want to give access to the data but not ownership, DLManagedTensorVersioned is the wrong type, that would be the job of DLTensor instead.
There was a problem hiding this comment.
Also, I'm not sure what's the use case is. If we want to give access to the data but not ownership, DLManagedTensorVersioned is the wrong type, that would be the job of DLTensor instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some stuff I ended up dumping. Might not be needed, driven by metatensor/metatensor#981