[MET-46] feat: dynamic data slot for each field #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanChe
reviewed
Dec 20, 2023
| let slot_updated = vec![owner.slot_updated, leaf.slot_updated] | ||
| .into_iter() | ||
| .max() | ||
| .unwrap(); // unwrap here is save, because vec is not empty |
There was a problem hiding this comment.
Suggested change
| .unwrap(); // unwrap here is save, because vec is not empty | |
| .unwrap(); // unwrap here is safe, because vec is not empty |
StanChe
reviewed
Dec 20, 2023
rocks-db/src/asset.rs
Outdated
| pub is_compressible: (u64, bool), | ||
| pub is_compressed: (u64, bool), | ||
| pub is_frozen: (u64, bool), | ||
| pub supply: (u64, Option<u64>), |
There was a problem hiding this comment.
Can you have a supply or seq or unchain_data with some slot updated and None value?
StanChe
reviewed
Dec 20, 2023
rocks-db/src/asset.rs
Outdated
| pub creators: Vec<Creator>, | ||
| pub royalty_amount: u16, | ||
| pub slot_updated: u64, | ||
| pub is_compressible: (u64, bool), |
There was a problem hiding this comment.
Maybe we need something like
struct Updated<T> {
slot_updated: u64,
value: T,
}
What do you think of that?
# Conflicts: # digital_asset_types/src/dao/scopes/asset.rs # nft_ingester/src/bubblegum_updates_processor.rs # nft_ingester/src/mplx_updates_processor.rs # nft_ingester/src/token_updates_processor.rs # rocks-db/src/asset.rs # rocks-db/src/batch_client.rs
# Conflicts: # nft_ingester/src/token_updates_processor.rs # rocks-db/src/asset.rs
RequescoS
changed the title
# Conflicts: # nft_ingester/src/api/service.rs
n00m4d
approved these changes
Dec 21, 2023
| @@ -33,6 +33,8 @@ export INGESTER_SLOT_UNTIL=0 | |||
| export INGESTER_SLOT_START_FROM=236032212 | |||
| export INGESTER_BIG_TABLE_CONFIG='{creds="./creds.json", timeout=1000}' | |||
|
|
|||
| export ingester_synchronizer_batch_size=500 | |||
There was a problem hiding this comment.
NIT: let's make capitalize for consistency?
| build: | ||
| context: . | ||
| dockerfile: migrator.Dockerfile | ||
|
|
||
| ingester-first-consumer: |
There was a problem hiding this comment.
Maybe we can drop ingester-second-consumer as well?
StanChe
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added slot_updated logic for each field in AssetDynamicDetails && AssetOwner structs. Refactored merge functions for this structs. Create insert_gaped_data function, that process CompleteAssetDetails. Wrote test for merge functions. Also this pr include some code clean up: removed unused imports in Cargo.toml for ingester and digital_asset_types, unused directories in project, adjust MakeFile and docker-compose.yaml etc